#167730747 Creating of trip requests

[OlawaleJoseph]

What does this PR do?

Enables users to create requests one-way, return, multi-city trip request

Description of Task to be completed?

• Ensure only users with a requester role can access this endpoint.
• Ensure requesters can create a one-way trip request.
• Ensure requesters can create a return trip request.
• Ensure requesters can create a multi-city trip request.

How should this be manually tested?

• git clone this repo using the command git clone git@github.com:andela/firestar-backend.git

• cd to the project

• checkout to the branch using the command git checkout ft-create-trips-167730747

• create a .env file and set PORT,JWT_SECRET and DB variables as specified in the .env.example file.

• Run the command npm install in the terminal.

• Open a terminal and run npm test.

• Open a terminal and run npm run migrate:dev and npm run seed:dev

• Open Postman, make a post request to localhost:port>/api/v1/auth/login, with any of the below
  in the request body.

• {email: abc123@gmail.com}

• {email: requester1@gmail.com}

• {email: requester2@gmail.com}

• {email: requester3@gmail.com}

  2. Copy the token in the reponse
  3. Make a POST request to http:localhost:<port>/api/v1/requests with the token obtained above in the request header as authorization=Bearer <token obtained>
  4. Send a request object containing the following for a one-way trip:
     { trip: { destinationLocationId: 2, departureLocationId: 1, accommodationId: 2, departureDate: '2020/10/10 18:00' }, reason: 'Business', departmentId: 2, tripType: 'oneWay', }
  5. Send a request object containing the following for a return trip:
     { initialTrip: { destinationLocationId: 2, departureLocationId: 1, accommodationId: 2, departureDate: '2020/10/10 18:00' }, returnTrip: { destinationLocationId: 1, departureLocationId: 2, departureDate: '2020/10/11 18:00' }, reason: 'Business', departmentId: 2, tripType: 'return', }
  6. Send a request object containing the following for a multi-city trip:
     { trips: [ { destinationLocationId: 2, departureLocationId: 1, accommodationId: 2, departureDate: '2020/10/10 18:00' }, { destinationLocationId: 1, departureLocationId: 2, departureDate: '2020/10/11 18:00' } ], reason: 'Business', departmentId: 2, tripType: 'multiCity', }
  7. Change values to check for edge cases.

Any background context you want to provide?

• A requester with an open request cannot make more requests
• The tripType can be either any of the following: oneWay, return, multiCity.
• The departure date of the first trip object must be at least a week from the time of testing. In a real-world scenario, a request needs to be made ahead of time.
• The departure dates of other trips except the first should be at least a day from each other. A user cannot travel to multiple countries in a day.
• The departure date format is either YYYY-MM-DD hh:mm:ss or YYYY/MM/DD hh:mm:ss
• When making a return trip ensure the destinationLocationId and departureLocationId are reversed for the return trip.
• When making a multi-city request, ensure your current location is your departureLocationId. See third image below for clarification. Note the flow of the destinationLocationId and departureLocationId.

What are the relevant pivotal tracker stories?

#167730747
#167730748
#167730749

Screenshots (if appropriate)

Questions:

N/A

[zanio]

[1] @OlawaleJoseph Nice job, please see the screenshot. display a relevant message if the type of body is not application/json

Also update your PR under task to be completed, You have done all of those you described as task to be completed.

Also I see that it is only a requester that can make a travel request. So what if a manager wants to travel ? A manager is also under somebody. Or I'm i not getting something right ?

[OlawaleJoseph]

[1] @OlawaleJoseph Nice job, please see the screenshot. display a relevant message if the type of body is not application/json

Also update your PR under task to be completed, You have done all of those you described as task to be completed.

Also I see that it is only a requester that can make a travel request. So what if a manager wants to travel ? A manager is also under somebody. Or I'm i not getting something right ?

@zanio Thanks for the response.
I will look to into the request body type.
I think task to be completed means, the tasks expected to be completed/features expected to be functional.
Lastly, according to the PT story, only a requester can make trip request.

[dewaleolaoye]

Well done!