#166236210 user signup #18

Ochowo · 2019-07-11T13:26:15Z

What does this PR do?

Users should be able to Signup on CSLC

Description of Task to be completed?

Setup the Signup component
Setup Redux
Test the component

Any background context you want to provide?

N/A

What are the relevant Github issues?

N/A

Questions:

N/A

Questions:

src/components/Inputs/Input.js

store/index.js

store/actions/authActions.js

src/views/home.js

src/views/Signup/SignUp.scss

store/reducers/authReducer.js

store/actions/types.js

store/actions/authActions.js

src/views/Signup/SignUpForm.js

src/views/Signup/SignUp.js

src/test/validations/validator.spec.js

src/test/reducers/authReducer.spec.js

src/test/components/heading.spec.js

src/test/actions/authAction.spec.js

src/components/heading/heading.js

src/components/Inputs/inputs.scss

src/components/Inputs/Input.js

src/components/Button/button.scss

src/components/Heading/heading.js

src/components/Button/button.scss

fortunee

Please fix all hound lint errors

src/views/Signup/SignUp.scss

src/components/Inputs/inputs.scss

src/views/Signup/SignUp.scss

src/components/Inputs/inputs.scss

src/views/Signup/SignUp.scss

[delivers #166236210]

src/views/Signup/SignUpForm.js

src/views/Signup/SignUp.js

src/index.js

src/views/Signup/SignUp.js

fortunee

👍

hound bot reviewed Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from a9b3108 to ec0cbbe Compare July 11, 2019 13:50

hound bot reviewed Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from ec0cbbe to 8955bc6 Compare July 11, 2019 14:10

hound bot reviewed Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from 8955bc6 to ea4d748 Compare July 11, 2019 14:29

hound bot reviewed Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from ea4d748 to 87cb31e Compare July 11, 2019 14:44

hound bot reviewed Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from 87cb31e to 6463a69 Compare July 11, 2019 15:11

hound bot reviewed Jul 11, 2019

View reviewed changes

src/components/Heading/heading.js Show resolved Hide resolved

src/components/Button/button.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch 2 times, most recently from 01fc9c4 to 32ba4ab Compare July 11, 2019 15:38

fortunee suggested changes Jul 11, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch 7 times, most recently from 515e1a4 to fa8754f Compare July 11, 2019 18:31

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 11, 2019 18:31 Failure

Ochowo force-pushed the ft-user-signup-166236210 branch from fa8754f to a962cf8 Compare July 11, 2019 19:14

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 11, 2019 19:14 Failure

Ochowo force-pushed the ft-user-signup-166236210 branch from a962cf8 to 4630c31 Compare July 11, 2019 19:43

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 11, 2019 19:43 Failure

hound bot reviewed Jul 11, 2019

View reviewed changes

src/views/Signup/SignUp.scss Show resolved Hide resolved

src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved

src/components/Inputs/inputs.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch from 4630c31 to 83c059b Compare July 11, 2019 19:54

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 11, 2019 19:54 Failure

hound bot reviewed Jul 11, 2019

View reviewed changes

src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch from 8587bdb to 71ac543 Compare July 11, 2019 21:14

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 11, 2019 21:14 Failure

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 12, 2019 07:17 Failure

hound bot reviewed Jul 12, 2019

View reviewed changes

src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved

src/components/Inputs/inputs.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch from 6548089 to 5c5de2d Compare July 12, 2019 07:49

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 12, 2019 07:49 Failure

Ochowo force-pushed the ft-user-signup-166236210 branch from 5c5de2d to 190049a Compare July 12, 2019 07:59

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 12, 2019 07:59 Failure

hound bot reviewed Jul 12, 2019

View reviewed changes

src/components/Inputs/inputs.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch from 190049a to 7d34c6f Compare July 12, 2019 08:02

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 12, 2019 08:02 Failure

hound bot reviewed Jul 12, 2019

View reviewed changes

src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved

Ochowo force-pushed the ft-user-signup-166236210 branch from 7d34c6f to d269242 Compare July 12, 2019 08:04

Tyak99 had a problem deploying to freyja-frontend-staging-pr-18 July 12, 2019 08:04 Failure

Ochowo added 4 commits July 15, 2019 10:34

feat(user): implement user signup

73d1b72

[delivers #166236210]

chore(test): Improve code coverage

68d9218

chore(feedback):implement LFA feedback

0647a0b

chore(errors)fix hound errors

3c8e470

Ochowo force-pushed the ft-user-signup-166236210 branch from d269242 to c3381a6 Compare July 15, 2019 09:38

Tyak99 temporarily deployed to freyja-frontend-staging-pr-18 July 15, 2019 09:38 Inactive

hound bot reviewed Jul 15, 2019

View reviewed changes

Ochowo force-pushed the ft-user-signup-166236210 branch from c3381a6 to d4ba496 Compare July 15, 2019 10:01

Ochowo temporarily deployed to freyja-frontend-staging-pr-18 July 15, 2019 10:01 Inactive

hound bot reviewed Jul 15, 2019

View reviewed changes

src/views/Signup/SignUp.js Outdated Show resolved Hide resolved

fix hound errors

f4fefa1

Ochowo force-pushed the ft-user-signup-166236210 branch from d4ba496 to f4fefa1 Compare July 15, 2019 10:07

Ochowo deployed to freyja-frontend-staging-pr-18 July 15, 2019 10:08 View deployment

fortunee approved these changes Jul 15, 2019

View reviewed changes

fortunee merged commit 988a5bd into develop Jul 15, 2019

Ochowo mentioned this pull request Jul 16, 2019

#167131517 Create static pages #167131517 #22

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#166236210 user signup #18

#166236210 user signup #18

Ochowo commented Jul 11, 2019

fortunee left a comment

fortunee left a comment

#166236210 user signup #18

#166236210 user signup #18

Conversation

Ochowo commented Jul 11, 2019

What does this PR do?

Description of Task to be completed?

Any background context you want to provide?

What are the relevant Github issues?

Questions:

Questions:

fortunee left a comment

Choose a reason for hiding this comment

fortunee left a comment

Choose a reason for hiding this comment