Ft 156577855 team access awareness #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change the branch you want to merge to from |
|
Your PR checklist needs fixing |
aenkya
requested changes
May 18, 2018
Pull Request Test Coverage Report for Build 273
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 273
💛 - Coveralls |
Pull Request Test Coverage Report for Build 273
💛 - Coveralls |
Pull Request Test Coverage Report for Build 296
💛 - Coveralls |
dondrzzy
force-pushed
the
ft-team-access-awareness-#156577855
branch
from
a8734bc
to
16f0fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures that users get to know that they can access an expanded dashboard that allows teams to collaboratively create and manage alerts based on the landing page UI/UX rework
Description of Task to be completed?
When a user wants to know what HealthChecks offers on accessing the landing page, they should be aware they should be aware that they can create teams and access/manage checks as a team.
How should this be manually tested?
2.Run the application and access the landing page
3: There should be a section that informs the user of the features that health checks has to offer.
What are the relevant pivotal tracker stories?
#156577855
Checklist: I completed these to help reviewers
My IDE is configured to follow the PEP8 Conventions
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendAll new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the develop branch.
No? Unsure? -> execute command
git pull --rebase origin develop