Ft 156577849 set user priorities #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
Pull Request Test Coverage Report for Build 294
💛 - Coveralls |
Ft 156577853 Update README.md
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…board-156577846 [feature #156577846] Create departments and add checks to departments
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
…ub.com/andela/hc-rogue-one into ft-list-of-users-be-notified-156577849
aenkya
reviewed
May 18, 2018
| @@ -5,9 +5,18 @@ $(function() { | |||
|
|
|||
| $("#rtm-email").text($this.data("email")); | |||
| $("#remove-team-member-email").val($this.data("email")); | |||
| console.log($this.data("email")) | |||
There was a problem hiding this comment.
These debug logs should be removed for merge to production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures that User should be able to set up a list of users(priority list) to be notified one after the other when a job fails until the alert is resolved
Description of Task to be completed?
A team access account super-user should be able to define who in the directory of the with team access should be notified about a failed job, when they should be notified and in what order
How should this be manually tested?
2.Run the application and click on account settings
3: Add a team member.
What are the relevant pivotal tracker stories?
#156577849
Checklist: I completed these to help reviewers
My IDE is configured to follow the PEP8 Conventions
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend[] I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendAll new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the develop branch.
No? Unsure? -> execute command
git pull --rebase origin develop