Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50798552 extend grace period #14

Merged
merged 17 commits into from
Sep 12, 2017

Conversation

Ashaba
Copy link

@Ashaba Ashaba commented Sep 11, 2017

What does this PR do?

It enables users to extend grace period beyond 30 days

Description of Task to be completed?

Users are now able to choose grace period up to 60 days for on the check

How should this be manually tested?

  1. Clone the repository
    git clone https://github.com/andela/healthchecks-invincibles.git
  2. Checkout the branch
    git checkout ft-extend-grace-period-150798552
  3. Activate the virtual environment and run the application
    ./manage.py runserver
  4. Visit the application URL, http://127.0.0.0.1:8000 and log in
  5. On the checks menu, click any checks available or create one and edit it's grace period

What are the relevant pivotal tracker stories?

#150798552

Screenshots (if appropriate)

image

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage increased (+1.1%) to 81.353% when pulling 423426f on ft-extend-grace-period-150798552 into df137bf on master.

@Ashaba Ashaba changed the base branch from master to develop September 11, 2017 15:01
@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 81.353% when pulling 171ab44 on ft-extend-grace-period-150798552 into c5c0eaa on develop.

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 81.353% when pulling 9e9abe2 on ft-extend-grace-period-150798552 into c5c0eaa on develop.

@judithachieng judithachieng merged commit b1f9c5f into develop Sep 12, 2017
@judithachieng judithachieng deleted the ft-extend-grace-period-150798552 branch September 12, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants