#145028655 Send alerts via sms #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Twilio integration for sending sms alerts. - Added sms integration option to the integrations page.
…/andela/Healthchecks_ThunkNalla into ft-send_alerts_via_sms-145028655
- Adding the latest requirements to the requirements file.
- Adding the latest requirements to the requirements file.
- Did some refactoring in the sms alerts configuration to fix the number to send to error that was apparent before.
collinmutembei
suggested changes
Jun 6, 2017
There was a problem hiding this comment.
I recommend removing the Twilio configurations from the repo's history as outlined in the link I shared a while back and load the settings through environment variables.
Resource: Twelve-Factor App
requirements.txt
Outdated
| @@ -1,9 +1,32 @@ | |||
| appdirs==1.4.3 | |||
There was a problem hiding this comment.
This file has conflicts, resolve them.
victoriaaoka
changed the title
davidmukiibi
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a feature that sends alerts on a user's job via SMS.
Description of Task to be completed?
Any background context you want to provide?
The feature is being developed by @davidmukiibi and @victoriaaoka.
What are the relevant pivotal tracker stories?
The pivotal tracker story for this work can be found here