Bug fix accounts tests #1

ianoti · 2016-12-14T07:05:56Z

The unit tests are in the five files under hc/accounts/tests.
The assigned tasks are under the comments in the hc/accounts/tests files.

…ociation ref[#135592991]

…word and send_report methods ref[#135592991]

…f[#135592991]

…5592991]

…ref[#135592991]

…t ref[#135592991]

coveralls · 2016-12-14T07:11:38Z

Coverage increased (+0.6%) to 80.873% when pulling eb4e75d on bug-fix_accounts_tests into 5a9fc32 on develop.

ianoti · 2016-12-14T10:28:11Z

hc/accounts/tests/test_check_token.py

@@ -22,7 +22,15 @@ def test_it_redirects(self):
        self.assertEqual(self.profile.token, "")

    ### Login and test it redirects already logged in
+    def test_it_redirects_if_already_logged_in(self):
+        self.client.login(username="alice@example.org", password="password")
+        r = self.client.get("/accounts/check_token/alice/secret-token/")


Use something more specific than r

ianoti · 2016-12-14T10:30:03Z

hc/accounts/tests/test_login.py

@@ -20,18 +20,23 @@ def test_it_sends_link(self):
        assert r.status_code == 302

        ### Assert that a user was created
+        self.assertEqual(len(User.objects.filter(email="alice@example.org")), 1)


Better assertion would be to assert user data rather than length

ianoti · 2016-12-14T10:35:08Z

hc/accounts/tests/test_login.py


        ### Assert that check is associated with the new user
+        self.test_user = User.objects.get(email="alice@example.org")
+        self.test_check = Check.objects.get(user=self.test_user.id)
+        self.assertEqual(self.test_user.id, self.test_check.user_id)

    def test_it_pops_bad_link_from_session(self):
        self.client.session["bad_link"] = True
        self.client.get("/accounts/login/")


Try putting in a bad link that gets popped out

ianoti · 2016-12-14T10:42:53Z

hc/accounts/tests/test_profile.py

@@ -41,10 +51,15 @@ def test_it_adds_team_member(self):
            member_emails.add(member.user.email)

        ### Assert the existence of the member emails
+        self.assertEqual(len(member_emails), 2) #Alice included as member

        self.assertTrue("frank@example.org" in member_emails)


DOn't hard code the email address

ianoti · 2016-12-14T10:47:04Z

hc/accounts/tests/test_profile.py

@@ -108,3 +123,20 @@ def test_it_shows_badges(self):
        self.assertNotContains(r, "bobs-tag.svg")


Assert that after adding a team member, an access allowed flag is present

After reviewing the code, the user Charlie doesn't have team access enabled hence why the expected error code is a 403 because access is being denied. the test for successful adding of a team member is handled in test_it_adds_team_member and the expected status code is 200 since Alice has team access enabled.

coveralls · 2016-12-14T13:11:03Z

Coverage increased (+0.6%) to 80.873% when pulling 595668c on bug-fix_accounts_tests into 5a9fc32 on develop.

…ref[#135592991]

coveralls · 2016-12-14T20:56:16Z

Coverage increased (+0.6%) to 80.873% when pulling 312bf7b on bug-fix_accounts_tests into 5a9fc32 on develop.

coveralls · 2016-12-14T21:17:28Z

Coverage increased (+0.6%) to 80.873% when pulling 4e67c3f on bug-fix_accounts_tests into 5a9fc32 on develop.

coveralls · 2016-12-14T21:24:03Z

Coverage increased (+0.6%) to 80.873% when pulling 644d3a3 on bug-fix_accounts_tests into 5a9fc32 on develop.

coveralls · 2016-12-14T21:31:50Z

Coverage increased (+0.6%) to 80.873% when pulling 644d3a3 on bug-fix_accounts_tests into 5a9fc32 on develop.

coveralls · 2016-12-14T21:38:17Z

Coverage increased (+0.6%) to 80.873% when pulling 644d3a3 on bug-fix_accounts_tests into 5a9fc32 on develop.

ianoti

I have worked on the changes. I believe the branch is ready for merging.

njirap · 2016-12-19T09:06:36Z

hc/accounts/tests/test_check_token.py

+    def test_it_redirects_if_already_logged_in(self):
+        self.client.login(username="alice@example.org", password="password")
+        response = self.client.get("/accounts/check_token/alice/secret-token/")
+        assert response.status_code == 302


maybe some consistency with the tests. If you are asserting the status code maybe assert for all

this assert is the main python assert and not the one for the base test class

njirap · 2016-12-19T09:14:38Z

hc/accounts/tests/test_login.py

@@ -20,18 +20,23 @@ def test_it_sends_link(self):
        assert r.status_code == 302

        ### Assert that a user was created
+        self.test_user = User.objects.get()


this is not a safe query when we have more than 1 user

njirap · 2016-12-19T09:17:44Z

hc/accounts/tests/test_login.py

@@ -20,18 +20,23 @@ def test_it_sends_link(self):
        assert r.status_code == 302

        ### Assert that a user was created
+        self.test_user = User.objects.get()
+        self.assertEqual(self.test_user.email, "alice@example.org")


maybe a better logic to test is assert that there is no user with a particular email, then create a user with that email, then assert that a user with that email now exixts and that the count of User objects has incremented by one.

njirap · 2016-12-19T09:33:19Z

hc/accounts/tests/test_profile.py

+        self.assertIsNotNone(self.alice.profile.api_key)
+        self.assertContains(response, "The API key has been created!")
+
+


what plans do you have for those two spaces?

njirap · 2016-12-19T09:41:02Z

hc/accounts/tests/test_switch_team.py

-        ### Assert the contents of r
+        ### Assert the contents of response
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed(response, "front/my_checks.html")


    def test_it_checks_team_membership(self):


maybe a better name for the test to have it less ambiguous

added uniform assertions for the redirect status code and PEP8 formatting added uniform assertions for the redirect status code and PEP8 formatting modified logic of testing for user creation and code for pep8 compliance minor edits to code to make assertions uniform and pep8 compliance minor edit to code for pep8 compliance and reworked logic for obtaining count of profile objects removed hardcoding of email in assertion test

ianoti added 11 commits December 12, 2016 22:28

added tests verifying user creation, email body content and check ass…

d76b231

…ociation ref[#135592991]

rewrote email body test for higher specificity ref[#135592991]

ad7464b

fixed bug of incorrect assertion ref[#135592991]

fcb696b

added tests for token set, and email subject and content for set_pass…

07d809b

…word and send_report methods ref[#135592991]

added tests for token creation, revoking, addition of team members re…

36977ae

…f[#135592991]

added test for redirecting if logged in and wrong token login ref[#13…

4d7fb5c

…5592991]

added tests for error codes and content of page when switching teams …

6fce4c8

…ref[#135592991]

added test asserting number of created profile objects ref[#135592991]

314f09e

added assertion for redirect url and rewrote client.post to client.ge…

5a91463

…t ref[#135592991]

added status code assertion to test_it_switches ref[#135592991]

9930679

reworked token test assertion in test_profile ref[#135592991]

eb4e75d

ianoti commented Dec 14, 2016

View reviewed changes

renamed variable r to response ref[#135592991]

595668c

rewrote test to check for creation of user by verifying user details …

312bf7b

…ref[#135592991]

ianoti added 3 commits December 15, 2016 00:08

removed hardcoding of email check in memeber_emails ref[#135592991]

a89963c

renamed variable r to response ref[#135592991]

4e67c3f

renamed variable r to response ref[#135592991]

9613121

ianoti commented Dec 14, 2016

View reviewed changes

njirap reviewed Dec 19, 2016

View reviewed changes

ianoti force-pushed the bug-fix_accounts_tests branch from e550151 to 86f11d3 Compare December 20, 2016 04:42

ianoti force-pushed the bug-fix_accounts_tests branch from 86f11d3 to 8fcd36c Compare December 20, 2016 10:18

mirabel-koso merged commit 42eed03 into develop Jan 5, 2017

mirabel-koso deleted the bug-fix_accounts_tests branch January 5, 2017 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix accounts tests #1

Bug fix accounts tests #1

ianoti commented Dec 14, 2016

coveralls commented Dec 14, 2016 •

edited

Loading

ianoti Dec 14, 2016

ianoti Dec 14, 2016 •

edited

Loading

ianoti Dec 14, 2016

ianoti Dec 14, 2016

ianoti Dec 14, 2016

ianoti Dec 14, 2016

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

ianoti left a comment

njirap Dec 19, 2016

njirap Dec 19, 2016

njirap Dec 19, 2016

njirap Dec 19, 2016

njirap Dec 19, 2016

njirap Dec 19, 2016

		@@ -108,3 +123,20 @@ def test_it_shows_badges(self):
		self.assertNotContains(r, "bobs-tag.svg")

		self.assertIsNotNone(self.alice.profile.api_key)
		self.assertContains(response, "The API key has been created!")

Bug fix accounts tests #1

Bug fix accounts tests #1

Conversation

ianoti commented Dec 14, 2016

coveralls commented Dec 14, 2016 • edited Loading

Choose a reason for hiding this comment

ianoti Dec 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 14, 2016 • edited Loading

coveralls commented Dec 14, 2016 • edited Loading

coveralls commented Dec 14, 2016 • edited Loading

coveralls commented Dec 14, 2016 • edited Loading

coveralls commented Dec 14, 2016 • edited Loading

coveralls commented Dec 14, 2016 • edited Loading

ianoti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 14, 2016 •

edited

Loading

ianoti Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading

coveralls commented Dec 14, 2016 •

edited

Loading