chore(refactor): fix hound error

andela · Apr 8, 2019 · e5a1c64 · e5a1c64
1 parent d01a1ea
commit e5a1c64
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/server/controllers/article.controllers.js b/server/controllers/article.controllers.js
@@ -79,12 +79,10 @@ const createArticle = async (req, res) => {
     req.body = spaceTrimmer(req.body);
     const article = await Article.create(req.body);
 
-    if (!req.body.is_draft) {
-      if (req.body.keywords) {
-        req.body.keywords.forEach(async keyword => {
-          await tagsHelpers.saveArticleTags(article.id, keyword);
-        });
-      }
+    if (!req.body.is_draft && req.body.keywords) {
+      req.body.keywords.forEach(async keyword => {
+        await tagsHelpers.saveArticleTags(article.id, keyword);
+      });
     }
 
     return res.status(201).json({

diff --git a/server/controllers/reset-password.controllers.js b/server/controllers/reset-password.controllers.js
@@ -32,11 +32,10 @@ const updatePassword = async (req, res) => {
   }
 };
 
-const acceptRequest = (req, res) => {
-  return res
+const acceptRequest = (req, res) =>
+  res
     .status(200)
     .redirect(`${req.protocol}://${req.get('host')}/api/v1/auth/reset/message`);
-};
 
 const ResetPasswordController = { updatePassword, acceptRequest };
 

diff --git a/server/helpers/server-error.js b/server/helpers/server-error.js
@@ -1,7 +1,4 @@
-const serverError = () => {
-  return {
-    body: ['Server error, Please try again later'],
-  };
-};
+const error = { body: ['Server error, Please try again later'] };
+const serverError = () => error;
 
 export default serverError;
diff --git a/server/helpers/validations.js b/server/helpers/validations.js
@@ -88,9 +88,7 @@ const validEditableProfileBody = body => {
   return valid;
 };
 
-const compareFieldWithToken = (field, token) => {
-  return field === token;
-};
+const compareFieldWithToken = (field, token) => field === token;
 
 const draftPublishMessage = isDraft => {
   if (isDraft) {