#165378746 User can get a list of suggested users to follow #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 16, 2019
server/helpers/aurhors-id-helper.js
Outdated
| @@ -0,0 +1,15 @@ | |||
| const getAuthorsIdFromArticle = (req, obj) => { | |||
| const allUserIds = obj.map(item => { | |||
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
| @@ -156,6 +156,17 @@ const patchProfile = async (req, res) => { | |||
| } | |||
| }; | |||
|
|
|||
| const controller = { getUserProfile, getProfileByField, patchProfile }; | |||
| const suggestedResearchers = (req, res) => { | |||
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
server/helpers/aurhors-id-helper.js
Outdated
|
|
||
| const uniqueIds = [...new Set(allUserIds)]; | ||
|
|
||
| const removeUserOwnId = uniqueIds.filter( |
There was a problem hiding this comment.
Give this is a better name. This sounds like the name of a function
server/routes/profile.routes.js
Outdated
| router.get( | ||
| '/suggested/researchers', | ||
| tokenValidator.verifyToken, | ||
| profileMiddleware.getAuthorOFArticleUserLiked, |
server/helpers/aurhors-id-helper.js
Outdated
|
|
||
| const uniqueIds = [...new Set(allUserIds)]; | ||
|
|
||
| const ids = uniqueIds.filter(item => item !== req.user.userObj.id); |
There was a problem hiding this comment.
You could just return uniqueIds.filter(...) directly
There was a problem hiding this comment.
And leave a comment explaining what it's doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a user has activities on the application, we can use those activities to suggest follows for the user.
Type of change
How Has This Been Tested?
Checklist:
PT-ID
#165378746
Screenshots
Questions:
N/A