#165429968 User can get their bookmarked articles #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2019 01:41
- create route - write test - add middleware - create controller - add documentation [Finishes 165429968]
- fix documentation [Finishes 165429968]
| const bookmarkController = { toggleBookmark }; | ||
| const userGetTheirBookmarkArticles = async (req, res) => { | ||
| try { | ||
| const bookmarkedArticle = await Bookmark.findAll({ |
There was a problem hiding this comment.
This should be bookmarkedArticles @AnayoOleru
added 2 commits
April 18, 2019 15:36
- edit variable name
…into feature/165429968-user-get-bookmark-articles
AnayoOleru
force-pushed
the
feature/165429968-user-get-bookmark-articles
branch
from
3cf8368
to
daaa14f
Compare
| @@ -62,5 +62,43 @@ const toggleBookmark = async (req, res) => { | |||
| } | |||
| }; | |||
|
|
|||
| const bookmarkController = { toggleBookmark }; | |||
| const userGetTheirBookmarkArticles = async (req, res) => { | |||
There was a problem hiding this comment.
You can name this getBookMarkedArticlesForUser. userGetTheirBookmarkArticles is just awkward @AnayoOleru
There was a problem hiding this comment.
You can name this
getBookMarkedArticlesForUser.userGetTheirBookmarkArticlesis just awkward @AnayoOleru
That's true. I've fixed it
added 2 commits
April 18, 2019 16:10
- edit function name
- refactor documentation
…into feature/165429968-user-get-bookmark-articles
rotimi-babalola
deleted the
feature/165429968-user-get-bookmark-articles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, users can bookmark articles, but they cannot get the articles they bookmarked. A user bookmarks articles to read them later or save them, but without the ability to get these bookmarked articles, they'll be saving articles for nothing. This P.R, adds the ability for a user to be able to get his/her articles they'd bookmarked.
Type of change
How Has This Been Tested?
Checklist:
PT-ID
#165429968
Screenshots
Questions:
N/A