Chore: Improve password strength #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use regular expression to strenght the passwords provided by the user - write tests
houndci-bot
reviewed
May 13, 2019
server/joiSchema/signupSchema.js
Outdated
| .alphanum() | ||
| .required(), | ||
| .regex(/^(?=.*[0-9])(?=.*[!@#$%^&=*])[a-zA-Z0-9!@#$%^&=*]{6,16}$/) | ||
| .error(() => { |
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the => arrow-body-style
There was a problem hiding this comment.
Please fix this hound issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the password validation for our backend to include special characters
Type of change
How Has This Been Tested?
Checklist:
PT-ID
N/A
Screenshots
N/A
Questions:
N/A