ft(helpers): create reusable functions #28
Conversation
| @@ -0,0 +1,55 @@ | |||
| import jwt from 'jsonwebtoken'; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
|
Fix merge conflicts in this PR |
- install jwt and bcrypt - create reusable function for hashing and comparing passwords - create reusable function foir signing and verifying jwt
Fixed |
server/models/rating.js
Outdated
| }); | ||
| }; | ||
| return Rating; | ||
| }; |
There was a problem hiding this comment.
This file is already in develop why is this showing us a change in this PR? @vic3king
There was a problem hiding this comment.
This file is already in develop why is this showing us a change in this PR? @vic3king
This is still from my rebase on branch develop. I've not had a reason to work with this file. I just pulled develop and rebased. Those changes are coming probably as a result of that rebase.
| }); | ||
| }, | ||
| down: queryInterface => queryInterface.dropTable('Ratings'), | ||
| }; |
There was a problem hiding this comment.
I'm not sure why. I pulled branch develop, checked out my branch and rebased. I didn't have to touch any of these files. Those files are what @McHardex i worked on. I will have to rebase again since his branch has been merged.
There was a problem hiding this comment.
@rotimi-babalola I have resolved this.
vic3king
force-pushed
the
ft-helper-functions-bcrypt-jwt
branch
from
01bfd3b
to
43e9bce
Compare
What does this PR do?
creates some reusable functions for signing tokens and hashing passwords
Description of Task to be completed?
How should this be manually tested?
NA
Any background context you want to provide?
NA
What are the relevant pivotal tracker stories?
NA
Screenshots
NA
Questions:
NA