Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167132066 setup title atom #14

Merged
merged 1 commit into from
Jul 9, 2019
Merged

#167132066 setup title atom #14

merged 1 commit into from
Jul 9, 2019

Conversation

frankly034
Copy link
Contributor

What does this PR do?

  • This PR sets up a Title atom with styleguide

Description of task to be completed?

  • add title atom
  • write tests for the title atom
  • add medium, large, xlarge font-size style variables
  • add style gui dist for Title

How should this be manually tested?

Any background context you want to provide?

  • You would need npm to run this application

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

image

@frankly034 frankly034 added the Ready for review This means a PR is ready for review by the teammates label Jul 9, 2019
@frankly034 frankly034 added Ready for review by TTL PR has been approved by at least two team members and ready to be reviewed by the TTL and removed Ready for review This means a PR is ready for review by the teammates labels Jul 9, 2019
@benfluleck benfluleck added Work in Progress and removed Ready for review by TTL PR has been approved by at least two team members and ready to be reviewed by the TTL labels Jul 9, 2019
feat(atom): setup title atom
31cb997 
- add title atom
- write tests for the title atom
- add medium, large, xlarge font size style variables
- add style gui dist for Title

[Finishes #167132066]
@frankly034 frankly034 added Ready for review by TTL PR has been approved by at least two team members and ready to be reviewed by the TTL and removed Work in Progress labels Jul 9, 2019
@benfluleck benfluleck merged commit 5a36d59 into develop Jul 9, 2019
@benfluleck benfluleck deleted the ft-title-atom-167132066 branch July 9, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinyeleolat akinyeleolat akinyeleolat approved these changes

@benfluleck benfluleck benfluleck approved these changes

@Sojisoyoye Sojisoyoye Sojisoyoye approved these changes

@EmmanuelSage EmmanuelSage Awaiting requested review from EmmanuelSage

@Eazybee Eazybee Awaiting requested review from Eazybee

@mosinmiloluwa01 mosinmiloluwa01 Awaiting requested review from mosinmiloluwa01

Assignees
No one assigned
Labels
Ready for review by TTL PR has been approved by at least two team members and ready to be reviewed by the TTL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frankly034 @akinyeleolat @benfluleck @Sojisoyoye