#167454777 create image with article row component #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
b3f542f
to
270f156
Compare
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
270f156
to
f32e954
Compare
Sojisoyoye
added
Ready for review
mosinmiloluwa01
suggested changes
Jul 25, 2019
Sojisoyoye
added
Work in Progress
and removed
Ready for review
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
f32e954
to
ecb948d
Compare
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
ecb948d
to
1df251d
Compare
Sojisoyoye
added
Ready for review
Sojisoyoye
requested review from
EmmanuelSage,
Eazybee,
frankly034 and
akinyeleolat
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
1df251d
to
73fe5db
Compare
benfluleck
reviewed
Jul 25, 2019
| theme, | ||
| }) => ` | ||
| display: ${display}; | ||
| text-align: ${textAlign}; | ||
| color: ${theme.textColors[color]}; | ||
| padding-bottom: ${theme.spacing[paddingBottom]}; | ||
| font-size: ${theme.fontSizes[fontSize]}; | ||
| font-family: ${(content === 'true' && 'Inknut Antiqua') || 'roboto'}; |
There was a problem hiding this comment.
Can you try ${content && 'Inknut Antiqua' || 'roboto'};
benfluleck
added
Work in Progress
and removed
Ready for review
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
73fe5db
to
4d4b0ad
Compare
- setup container for the atoms - include image atom - include text and title atom - write test for component [Finishes #167454777]
Sojisoyoye
force-pushed
the
ft-image-text-molecule-167454777
branch
from
4d4b0ad
to
3a0329f
Compare
Sojisoyoye
added
Ready for review by TTL
benfluleck
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets up image with article component
Description of task to be completed?
How should this be manually tested?
$ git clone https://github.com/andela/king-kong-ah-frontend.git
$ npm install
$ npm test
Any background context you want to provide?
You would need npm to run this application
What are the relevant pivotal tracker stories?
PT Story link - #167454777
Screenshots (if appropriate)