#167749954 Implement Password Reset Feature #24

daviddamilola · 2019-09-06T10:24:57Z

What does this PR do?

Add password reset feature

Description of Task to be completed?

add test for password reset endpoint
add password reset endpoint routes.
add update Password service.
add verify email and send email Helper.
add password validation user schema.
update documentation.

How should this be manually tested?

git clone the branch
set the environment variables
run postman
send a POST request to /api/v1/users/reset
send a PATCH request containing the new password to the link in the email

Any background context you want to provide?

nodemailer was used to send the email.

What are the relevant pivotal tracker stories?

#167749954

hustlaviola · 2019-09-09T12:06:57Z

.travis.yml

@@ -9,6 +9,11 @@ before_script:
 node_js:
 - 'stable'

+env:


You can remove the environment variables, it has been added on Travis

changes have been implemented.

src/config/swagger.json

hustlaviola · 2019-09-09T12:14:56Z

src/config/swagger.json

+              "firstname": {
+                "type": "string"
+              },
+              "lastname": {


Suggested change

"lastname": {

"lastName": {

changes have been implemented

hustlaviola · 2019-09-09T12:23:07Z

src/controllers/UserController.js

+      Responses.setError(400, 'this address link has expired')
+      return Responses.send(res);
+    }
+    if (req.method == 'GET') {


Suggested change

if (req.method == 'GET') {

if (req.method === 'GET') {

changes have been implemented

hustlaviola · 2019-09-09T12:28:55Z

src/database/models/user.js

@@ -19,4 +20,4 @@ export default (sequelize, DataTypes) => {
    },
  }, {});
  return User;
-};
+};


You can always add newlines at the end of a file

Naimaoye

Good job David. I think you need to add new lines at the end of some of your files, please check through

hustlaviola

A lot of files does not have newlines at the end. Consider adding them. You can also rebase off ft-JWT-auth-167749949 to implement some changes on your branch. This is good work, well done.

hustlaviola · 2019-09-09T16:19:37Z

src/routes/index.js

@@ -0,0 +1,11 @@
+import express from 'express';


This file has been deleted. Consider rebasing

hustlaviola · 2019-09-09T16:22:20Z

src/tests/index.test.js

@@ -18,13 +18,13 @@ describe('Handle requests on other endpoints', () => {
      });
  });

-  it('should return an error when a wrong url is provided', done => {
+  it('should return a welcome message for version 1 of the API', done => {


This test has been removed as well

hound · 2019-09-12T06:42:33Z

src/utils/Helper.js

+    * @memberof Helper
+    */
+  static async verifyExistingEmail(email) {
+    const check = await models.User.findOne({ where: { email , isVerified: true} });


A space is required before '}' object-curly-spacing
There should be no space before ',' comma-spacing

hound · 2019-09-12T17:11:15Z

src/tests/user.test.js

      })
      .end((err, res) => {
+        console.log(res.body);


Unexpected console statement no-console

hound · 2019-09-12T17:11:15Z

src/controllers/RequestController.js

@@ -2,6 +2,7 @@ import RequestService from '../services/RequestService';
 import Responses from '../utils/Responses';
 import Helper from '../utils/Helper';

+console.log(Helper.hashPassword('Frank1234'));


Unexpected console statement no-console

hustlaviola · 2019-09-12T18:43:09Z

src/config/swagger.json

+          }
+        ],
+        "responses": {
+          "201": {


You can change the status code here

Suggested change

"201": {

"200": {

hustlaviola · 2019-09-12T18:46:50Z

src/controllers/UserController.js

+      id, email, createdAt, updatedAt
+    } = rowsAffected;
+    Responses.setSuccess(
+      201,


Suggested change

201,

200,

Thanks for the feedback @hustlaviola , changes have been implemented.

hound · 2019-09-16T12:24:30Z

src/controllers/UserController.js

    return Responses.send(res);
  }
-}
+}


Newline required at end of file but not found eol-last

- add test for password reset endpoint - add password reset endpoint routes. - add update Password service. - add verify email and send email Helper. - add password validation userSchema. - update documentation. [Delivers #167749954]

ldonjibson · 2022-09-21T08:57:05Z

you still dey work on the stuff?

daviddamilola requested review from hustlaviola, alatos2, Naimaoye and ibraheem-adeyemo September 6, 2019 10:25

daviddamilola force-pushed the ft-password-reset-167749954 branch from 3f84680 to 872150e Compare September 6, 2019 23:12

daviddamilola added the work in progress label Sep 7, 2019

daviddamilola force-pushed the ft-password-reset-167749954 branch 3 times, most recently from e7c6e61 to a19f684 Compare September 8, 2019 19:16

daviddamilola added peer review and removed work in progress labels Sep 8, 2019

daviddamilola force-pushed the ft-password-reset-167749954 branch 2 times, most recently from 8b16e85 to db4c3db Compare September 9, 2019 07:04

daviddamilola added the ready for merge label Sep 9, 2019

ldonjibson approved these changes Sep 9, 2019

View reviewed changes