feature(List users functionality): Users should be able to view other…

… users profile

Apply TTL feedback
[Fixes #162727477]

src/controllers/UsersController.js

@@ -301,16 +301,6 @@ class UsersController {
     try {
       const { artistId } = req.params;
 
-      /* eslint-disable no-restricted-globals */
-      if (isNaN(artistId)) {
-        const response = new Response(
-          'Bad Request',
-          400,
-          'Artist ID must be an integer',
-        );
-        return res.status(response.code).json(response);
-      }
-
       const artist = await User.findOne({
         where: {
           id: artistId,

src/middlewares/UserMiddleware.js

@@ -103,6 +103,29 @@ class UserMiddleware {
       return res.status(response.code).json(response);
     }
   }
+
+  /**
+ * Validate Password
+ * @param {object} req
+ * @param {object} res
+ * @param {function} next
+ * @memberof UserMiddleware
+ * @returns {object} error object if artist id is not a number
+ */
+  static async validateArtistID(req, res, next) {
+    const { artistId } = req.params;
+    /* eslint-disable no-restricted-globals */
+    if (isNaN(artistId)) {
+      const response = new Response(
+        'Bad Request',
+        400,
+        'Artist ID must be an integer',
+      );
+      return res.status(response.code).json(response);
+    }
+
+    next();
+  }
 }
 
 export default UserMiddleware;

src/routes/userRouter.js

@@ -1,6 +1,7 @@
 import express from 'express';
 import UsersController from '../controllers/UsersController';
 import TokenAuthenticate from '../helpers/TokenAuthenticate';
+import UserMiddleware from '../middlewares/UserMiddleware';
 
 const userRouter = express.Router();
 
@@ -13,6 +14,7 @@ userRouter.get(
 userRouter.get(
   '/artists/:artistId',
   TokenAuthenticate.tokenVerify,
+  UserMiddleware.validateArtistID,
   UsersController.getOneArtist,
 );