#162727467 Enable social login #18

abejide001 · 2019-01-16T14:36:44Z

What does this PR do?

Implement Social(twitter, facebook and google) authentication

Description of Task to be completed?

Write logic for login via twitter using passport twitter
Write logic for login via facebook using passport facebook
Write logic for login via google using passport google
Write test for social controller
Modify password and userType to allowNull

How should this be manually tested?

Run npm i
Please contact the developer for application secrets
On the browser, enter the following URL
-for facebook localhost:9000/api/v1/auth/facebook
-for twitter localhost:9000/api/v1/auth/twitter
-for google localhost:9000/api/v1/auth/google
The URL return the following data
message and token

Any background context you want to provide?

Twitter takes time to supply the consumer secret(about 5hours), and allowNull was set to true for password and userType, because the response coming in does not contain password, and the userType can be edited after the logs in and edit profile

What are the relevant pivotal tracker stories?

162727467

Screenshots (if appropriate)

#### Questions: N/A

Implement social controller Add services folder, and implement strategy for twitter, facebook, and google Modify migrations, and allowNull for password and signUpType Write test for Social Controller [Delivers #162727467]

Implement social controller Add services folder, and implement strategy for twitter, facebook, and google Modify migrations, and allowNull for password and signUpType Write test for Social Controller Fix merge conflicts [Delivers 162727467]

houndci-bot · 2019-01-16T14:37:19Z

test/controllers/socialControllerTest.js

@@ -0,0 +1,92 @@
+import 'babel-polyfill';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2019-01-16T14:37:19Z

src/services/passport.js

@@ -0,0 +1,32 @@
+/* eslint-disable no-underscore-dangle */
+import passport from 'passport';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2019-01-16T14:37:20Z

src/routes/socialRouter.js

@@ -0,0 +1,25 @@
+import express from 'express';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2019-01-16T14:37:20Z

src/controllers/SocialsController.js

@@ -0,0 +1,174 @@
+/* eslint-disable no-underscore-dangle */
+/* eslint-disable camelcase */
+import models from '../db/models';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2019-01-18T11:36:56Z

src/routes/socialRouter.js

+  passport.authenticate('twitter', { scope: ['include_email =true'] }));
+
+socialRouter.get('/twitter/callback',
+  passport.authenticate('twitter'), SocialController.getToken);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-01-18T11:36:56Z

src/routes/socialRouter.js

+socialRouter.get('/twitter',
+  passport.authenticate('twitter', { scope: ['include_email =true'] }));
+
+socialRouter.get('/twitter/callback',


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-01-18T11:36:56Z

src/routes/socialRouter.js

+  passport.authenticate('google'), SocialController.getToken);
+
+socialRouter.get('/twitter',
+  passport.authenticate('twitter', { scope: ['include_email =true'] }));


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-01-18T11:36:56Z

src/routes/socialRouter.js

+socialRouter.get('/google/callback',
+  passport.authenticate('google'), SocialController.getToken);
+
+socialRouter.get('/twitter',


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-01-18T11:36:57Z

src/routes/socialRouter.js

+  passport.authenticate('google', { scope: ['profile', 'email'] }));
+
+socialRouter.get('/google/callback',
+  passport.authenticate('google'), SocialController.getToken);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-01-18T11:36:57Z

src/routes/socialRouter.js

+
+socialRouter.get('/facebook/callback',
+  passport.authenticate('facebook'), SocialController.getToken);
+socialRouter.get('/google',


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-01-18T11:36:57Z

src/routes/socialRouter.js

+  passport.authenticate('facebook', { scope: ['email'] }));
+
+socialRouter.get('/facebook/callback',
+  passport.authenticate('facebook'), SocialController.getToken);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-01-18T11:36:57Z

src/routes/socialRouter.js

+socialRouter.get('/facebook',
+  passport.authenticate('facebook', { scope: ['email'] }));
+
+socialRouter.get('/facebook/callback',


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-01-18T11:36:57Z

src/routes/socialRouter.js

+const socialRouter = express.Router();
+
+socialRouter.get('/facebook',
+  passport.authenticate('facebook', { scope: ['email'] }));


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-01-18T11:36:58Z

src/routes/socialRouter.js

+
+const socialRouter = express.Router();
+
+socialRouter.get('/facebook',


Expected a newline after '(' function-paren-newline

andela-dbamidele

Looking good 👍

andela-dbamidele · 2019-01-21T09:26:32Z

src/controllers/SocialsController.js

+        });
+      }
+      userDetails.newUser = isCreated;
+      return done(null, userDetails);


Why are you using a callback? It's required by passport?

andela-dbamidele · 2019-01-21T09:33:25Z

src/controllers/SocialsController.js

+    const {
+      displayName, emails,
+    } = profile;
+    const { bio } = profile || null;


This will crash the app when/if profile is not available and it resolves to null; You might want to do something like

const bio = profile.bio || null;

okay, on it.

andela-dbamidele · 2019-01-21T09:33:38Z

src/controllers/SocialsController.js

+      displayName, emails,
+    } = profile;
+    const { bio } = profile || null;
+    const { imgURL } = profile || null;


andela-dbamidele · 2019-01-21T09:34:00Z

src/controllers/SocialsController.js

+    const {
+      displayName, emails,
+    } = profile;
+    const { bio } = profile || null;


okay, on it.

andela-dbamidele · 2019-01-21T09:34:12Z

src/controllers/SocialsController.js

+      displayName, emails,
+    } = profile;
+    const { bio } = profile || null;
+    const { imgURL } = profile || null;


okay, on it.

julietezekwe

Looks good

wombolo

LGTM

abejide001 added 2 commits January 16, 2019 14:28

feat(social-auth): implement social authentication

a31d711

Implement social controller Add services folder, and implement strategy for twitter, facebook, and google Modify migrations, and allowNull for password and signUpType Write test for Social Controller [Delivers #162727467]

abejide001 requested review from andela-dbamidele, julietezekwe and daniellamarr January 16, 2019 14:36

houndci-bot reviewed Jan 16, 2019

View reviewed changes

fix(email): set condition for sending emails

f17b111

houndci-bot reviewed Jan 18, 2019

View reviewed changes

fix(hound): fix hound errors

1649d6a

andela-dbamidele suggested changes Jan 21, 2019

View reviewed changes

julietezekwe approved these changes Jan 21, 2019

View reviewed changes

fix(feedback) Implement TTL's feedback

f5a20c0

wombolo self-requested a review January 21, 2019 12:14

wombolo approved these changes Jan 21, 2019

View reviewed changes

Proception approved these changes Jan 21, 2019

View reviewed changes

andela-dbamidele approved these changes Jan 22, 2019

View reviewed changes

andela-dbamidele merged commit 9887ced into staging Jan 22, 2019

andela-dbamidele deleted the feature/162727467/enable-social-login branch January 22, 2019 00:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#162727467 Enable social login #18

#162727467 Enable social login #18

abejide001 commented Jan 16, 2019

houndci-bot Jan 16, 2019

houndci-bot Jan 16, 2019

houndci-bot Jan 16, 2019

houndci-bot Jan 16, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

houndci-bot Jan 18, 2019

andela-dbamidele left a comment

andela-dbamidele Jan 21, 2019

abejide001 Jan 21, 2019

andela-dbamidele Jan 21, 2019

abejide001 Jan 21, 2019

andela-dbamidele Jan 21, 2019

andela-dbamidele Jan 21, 2019

abejide001 Jan 21, 2019

andela-dbamidele Jan 21, 2019

abejide001 Jan 21, 2019

julietezekwe left a comment

wombolo left a comment

		@@ -0,0 +1,32 @@
		/* eslint-disable no-underscore-dangle */
		import passport from 'passport';


		const socialRouter = express.Router();

		socialRouter.get('/facebook',

#162727467 Enable social login #18

#162727467 Enable social login #18

Conversation

abejide001 commented Jan 16, 2019

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andela-dbamidele left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julietezekwe left a comment

Choose a reason for hiding this comment

wombolo left a comment

Choose a reason for hiding this comment