#162727487 comment update history #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Feature #162727487]
…into feature/162727487/comment-update-history Merge staging to current branch .
Write test for edit history implement get all edit histroy implement create edit history write validation for comment update body [Feature #162727487]
houndci-bot
reviewed
Jan 23, 2019
| @@ -0,0 +1,23 @@ | |||
| module.exports = { | |||
andela-dbamidele
approved these changes
Jan 26, 2019
| const { body } = req.body; | ||
| const { commentId } = req.params; | ||
| const { id } = req.verifyUser; | ||
| const findComment = await Comment.find({ |
There was a problem hiding this comment.
Can we move this to the middleware. I think it will make more sense there.
There was a problem hiding this comment.
Oh just seeing this. will do now
[Fixed #162727487/]
houndci-bot
reviewed
Jan 26, 2019
| @@ -0,0 +1,58 @@ | |||
| import models from '../db/models'; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
…into feature/162727487/comment-update-history
[Fixed #162727487]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements comment edit history track
Description of Task to be completed?
Comment edit history can be saved and be retrieved
How should this be manually tested?
On the update comment route PUT
/api/v1/arts/comments/commentIdUpdate a comment with a certain more as many times as you want
Hit GET
/api/v1/arts/coments/commentIdwith same ID and get all the edit historyAny background context you want to provide?
Run
npm run db:seedbefore testingWhat are the relevant pivotal tracker stories?
#162727487
Screenshots (if appropriate)
None
Questions:
None