#164109890 add redirect to social controller #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 21, 2019
src/controllers/SocialsController.js
Outdated
| import models from '../db/models'; | ||
| import TokenAuthenticate from '../helpers/TokenAuthenticate'; | ||
| import Response from '../helpers/response'; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| const { FRONTEND_BASE_PATH } = process.env |
src/controllers/SocialsController.js
Outdated
| @@ -1,9 +1,14 @@ | |||
| /* eslint-disable no-underscore-dangle */ | |||
| /* eslint-disable camelcase */ | |||
| import dotenv from 'dotenv' | |||
| if (newUser) { | ||
| response = new Response( | ||
| 'Ok', | ||
| 201, | ||
| 'User logged in successfully', | ||
| { token } | ||
| ); | ||
| return res.status(response.code).json(response); | ||
| return res.redirect(`${FRONTEND_BASE_PATH}/auth?token=${token}`); |
There was a problem hiding this comment.
Why are you redirecting from the server? I'll go ahead and merge this in the meantime though
andela-dbamidele
approved these changes
Feb 24, 2019
|
I also don't know why you removed some test @Proception. Please find time to fix the test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a redirect to the social authentication process to the frontend
Description of Task to be completed?
How should this be manually tested?
npm run start:devhttp://localhost:9000/api/v1/auth/{provider}/callbackAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#164109890
Screenshots (if appropriate)
N/A