#159987407 User can post comments #12

jamesenejo · 2018-09-07T05:41:44Z

What does this PR do?

Adds a commenting feature to the application
Stops sending descriptive errors to users when logging fails.

Description of Task to be completed?

Have the commenting endpoint working
/api/v1/articles/:articleId

How should this be manually tested?

After cloning the repo, cd into it and run 'npm start'
Using postman, you can test the endpoint

What are the relevant pivotal tracker stories?

#159987407

houndci-bot · 2018-09-07T05:42:06Z

test/test.articles.js

+          password: 'pasS1234',
+        })
+        .end((err, res) => {
+          token = res.body.data.token;


Use object destructuring prefer-destructuring

houndci-bot · 2018-09-07T05:42:06Z

test/test.articles.js

@@ -0,0 +1,88 @@
+import chai from 'chai';
+import chaiHttp from 'chai-http';
+import app from '../server/app';


Missing file extension for "../server/app" import/extensions

houndci-bot · 2018-09-07T05:42:06Z

test/test.articles.js

@@ -0,0 +1,88 @@
+import chai from 'chai';
+import chaiHttp from 'chai-http';


Missing file extension for "chai-http" import/extensions

houndci-bot · 2018-09-07T05:42:06Z

test/test.articles.js

@@ -0,0 +1,88 @@
+import chai from 'chai';


Missing file extension for "chai" import/extensions

houndci-bot · 2018-09-07T05:42:06Z

server/utils/generateToken.js

@@ -0,0 +1,14 @@
+import jwt from 'jsonwebtoken';
+import dotenv from 'dotenv';
+import Cryptr from 'cryptr';


Missing file extension for "cryptr" import/extensions

houndci-bot · 2018-09-07T05:42:07Z

server/routes/articlesRoutes.js

@@ -0,0 +1,13 @@
+import express from 'express';


Missing file extension for "express" import/extensions

houndci-bot · 2018-09-07T05:42:08Z

server/models/users.js

@@ -1,3 +1,5 @@
+import bcrypt from 'bcrypt';


Missing file extension for "bcrypt" import/extensions

houndci-bot · 2018-09-07T05:42:08Z

server/middleware/auth.js

@@ -0,0 +1,42 @@
+import jwt from 'jsonwebtoken';
+import { config } from 'dotenv';
+import Cryptr from 'cryptr';


Missing file extension for "cryptr" import/extensions

houndci-bot · 2018-09-07T05:42:08Z

server/middleware/auth.js

@@ -0,0 +1,42 @@
+import jwt from 'jsonwebtoken';
+import { config } from 'dotenv';


Missing file extension for "dotenv" import/extensions

houndci-bot · 2018-09-07T05:42:08Z

server/middleware/auth.js

@@ -0,0 +1,42 @@
+import jwt from 'jsonwebtoken';


Missing file extension for "jsonwebtoken" import/extensions

coveralls · 2018-09-07T05:43:18Z

Pull Request Test Coverage Report for Build 368

29 of 30 (96.67%) changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 92.612%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
server/controllers/commentController.js	10	11	90.91%

Files with Coverage Reduction	New Missed Lines	%
server/helpers/ratingHelpers.js	2	84.62%

Totals
Change from base Build 366:	-0.4%
Covered Lines:	445
Relevant Lines:	483

💛 - Coveralls

iAmao

Nice, but git workflow could have been better. Try and level up in this area

iAmao · 2018-09-07T11:24:59Z

server/controllers/commentsController.js

+      .then(comment => Users.findById(userId, {
+        attributes: ['id', 'username', 'firstname', 'lastname', 'createdAt', 'updatedAt']
+      })
+        .then(user => res.status(201).jsend.success({ user, comment })));


No catch block. We always need to handle cases like this. Just in case

houndci-bot · 2018-09-07T19:18:21Z

server/middleware/usersValidations.js

@@ -1,4 +1,11 @@
-import helper from '../helpers/helpers';
+import helpers from '../helpers/helpers';


Missing file extension for "../helpers/helpers" import/extensions

houndci-bot · 2018-09-07T19:18:22Z

server/middleware/articlesValidations.js

@@ -0,0 +1,22 @@
+import helpers from '../helpers/helpers';


Missing file extension for "../helpers/helpers" import/extensions

houndci-bot · 2018-09-07T19:18:22Z

server/controllers/commentsController.js

@@ -0,0 +1,31 @@
+import validator from 'validator';
+import models from '../models/index';


Missing file extension for "../models/index" import/extensions

houndci-bot · 2018-09-07T19:18:22Z

server/controllers/commentsController.js

@@ -0,0 +1,31 @@
+import validator from 'validator';


Missing file extension for "validator" import/extensions

houndci-bot · 2018-09-07T19:18:22Z

server/app.js

@@ -5,6 +5,7 @@ import swaggerUi from 'swagger-ui-express';
 import jsend from 'jsend';
 import swaggerDocument from '../swagger.json';
 import userRoutes from './routes/userRoutes';
+import articlesRoutes from './routes/articlesRoutes';


Missing file extension for "./routes/articlesRoutes" import/extensions

houndci-bot · 2018-09-11T11:04:06Z

test/test.articles.js

+          password: 'pasS1234',
+        })
+        .end((err, res) => {
+          token = res.body.data.token;


Use object destructuring prefer-destructuring

houndci-bot · 2018-09-11T17:33:26Z

test/comments.spec.js

+          password: 'pasS1234',
+        })
+        .end((err, res) => {
+          token = res.body.data.token;


Use object destructuring prefer-destructuring

houndci-bot · 2018-09-11T17:33:27Z

test/comments.spec.js

+          password: 'pasS1234',
+        })
+        .end((err, res) => {
+          token = res.body.data.token;


Use object destructuring prefer-destructuring

- add article routes - add seed to initialise a user, category and article - create controller to handle comment posts - create middleware validate user comments - update documentation to capture new route - write tests to test endpoint functionality - refactor usersValidations to confirm with ES6 syntax and not to send descriptive errors when logging in [Delivers ##159987407] feat(comment): user can comment - add article routes - add seed to initialise a user, category and article - create controller to handle comment posts - create middleware validate user comments - update documentation to capture new route - write tests to test endpoint functionality [Delivers ##159987407] feat(comment): user can comment - add article routes - add seed to initialise a user, category and article - create controller to handle comment posts - create middleware validate user comments - update documentation to capture new route - write tests to test endpoint functionality - refactor usersValidations to confirm with ES6 syntax and not to send descriptive errors when logging in [Delivers ##159987407] update tests

houndci-bot · 2018-09-14T01:57:03Z

test/comments.spec.js

+          password: 'Password'
+        })
+        .end((err, res) => {
+          token = res.body.data.token;


Use object destructuring prefer-destructuring

houndci-bot reviewed Sep 7, 2018

View reviewed changes

iAmao suggested changes Sep 7, 2018

View reviewed changes

jamesenejo force-pushed the ft-user-can-comment-159987407 branch from 3123696 to 69cba1f Compare September 7, 2018 19:18

jojitoon temporarily deployed to metis-ah-staging-pr-12 September 7, 2018 19:18 Inactive

houndci-bot reviewed Sep 7, 2018

View reviewed changes

jamesenejo force-pushed the ft-user-can-comment-159987407 branch from 69cba1f to a5b2603 Compare September 7, 2018 19:34

jojitoon temporarily deployed to metis-ah-staging-pr-12 September 7, 2018 19:35 Inactive

jojitoon temporarily deployed to metis-ah-staging-pr-12 September 11, 2018 11:03 Inactive

houndci-bot reviewed Sep 11, 2018

View reviewed changes

jamesenejo force-pushed the ft-user-can-comment-159987407 branch from 01c1fdf to 3c94038 Compare September 11, 2018 11:42

jojitoon temporarily deployed to metis-ah-staging-pr-12 September 11, 2018 11:43 Inactive

jojitoon deployed to metis-ah-staging-pr-12 September 11, 2018 13:49 View deployment

jamesenejo force-pushed the ft-user-can-comment-159987407 branch from aa4ab28 to 8733381 Compare September 11, 2018 17:31

jojitoon had a problem deploying to metis-ah-staging-pr-12 September 11, 2018 17:31 Failure

houndci-bot reviewed Sep 11, 2018

View reviewed changes

jamesenejo force-pushed the ft-user-can-comment-159987407 branch from 8733381 to 37e6f39 Compare September 14, 2018 01:56

jojitoon had a problem deploying to metis-ah-staging-pr-12 September 14, 2018 01:56 Failure

houndci-bot reviewed Sep 14, 2018

View reviewed changes

iAmao approved these changes Sep 14, 2018

View reviewed changes

iAmao merged commit c7b9dfc into develop Sep 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#159987407 User can post comments #12

#159987407 User can post comments #12

jamesenejo commented Sep 7, 2018 •

edited

Loading

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

coveralls commented Sep 7, 2018 •

edited

Loading

iAmao left a comment

iAmao Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 7, 2018

houndci-bot Sep 11, 2018

houndci-bot Sep 11, 2018

houndci-bot Sep 11, 2018

houndci-bot Sep 14, 2018

		@@ -0,0 +1,88 @@
		import chai from 'chai';
		import chaiHttp from 'chai-http';

		@@ -0,0 +1,42 @@
		import jwt from 'jsonwebtoken';
		import { config } from 'dotenv';

		@@ -1,4 +1,11 @@
		import helper from '../helpers/helpers';
		import helpers from '../helpers/helpers';

		@@ -0,0 +1,31 @@
		import validator from 'validator';
		import models from '../models/index';

#159987407 User can post comments #12

#159987407 User can post comments #12

Conversation

jamesenejo commented Sep 7, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 7, 2018 • edited Loading

Pull Request Test Coverage Report for Build 368

💛 - Coveralls

iAmao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamesenejo commented Sep 7, 2018 •

edited

Loading

coveralls commented Sep 7, 2018 •

edited

Loading