#161280586 user can get an authors article #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 17, 2018
| @@ -1,4 +1,9 @@ | |||
| import GetAuthorsOfTheWeekHelpers from '../helpers/GetAuthorsOfTheWeekHelpers'; | |||
| import models from '../models'; | |||
| import helpers from '../helpers/helpers'; | |||
There was a problem hiding this comment.
Missing file extension for "../helpers/helpers" import/extensions
| @@ -1,4 +1,9 @@ | |||
| import GetAuthorsOfTheWeekHelpers from '../helpers/GetAuthorsOfTheWeekHelpers'; | |||
| import models from '../models'; | |||
There was a problem hiding this comment.
Missing file extension for "../models" import/extensions
| @@ -2,6 +2,7 @@ import chai from 'chai'; | |||
| import chaiHttp from 'chai-http'; | |||
| import app from '../server/app'; | |||
| import GetAuthorsOfTheWeekHelpers from '../server/helpers/GetAuthorsOfTheWeekHelpers'; | |||
| import generateToken from '../server/helpers/generateToken'; | |||
There was a problem hiding this comment.
Missing file extension for "../server/helpers/generateToken" import/extensions
| @@ -1,9 +1,12 @@ | |||
| import express from 'express'; | |||
| import authorController from '../controllers/authorController'; | |||
| import authorController, { getArticlesByAuthorsId } from '../controllers/authorController'; | |||
There was a problem hiding this comment.
Missing file extension for "../controllers/authorController" import/extensions
Pull Request Test Coverage Report for Build 621
💛 - Coveralls |
joeeasy
force-pushed
the
ft-user-can-view-author-article-#161280586
branch
from
c7f50f4
to
82715ac
Compare
houndci-bot
reviewed
Oct 17, 2018
| @@ -1,9 +1,13 @@ | |||
| import express from 'express'; | |||
| import authorController from '../controllers/authorController'; | |||
| import authorController, { getArticlesByAuthorsId } from '../controllers/authorController'; | |||
| import auth from '../middleware/auth'; | |||
There was a problem hiding this comment.
Missing file extension for "../middleware/auth" import/extensions
iAmao
suggested changes
Oct 17, 2018
| message: 'All articles', | ||
| articles | ||
| }) | ||
| : res.status(404).jsend.success({ |
There was a problem hiding this comment.
Let's return an empty array if no articles are present
- Users can view the articles of an author [finishes #161280586]
joeeasy
force-pushed
the
ft-user-can-view-author-article-#161280586
branch
from
82715ac
to
68f6e9d
Compare
iAmao
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an endpoint for fetching author's articles
Description of Task to be completed?
/authors/articles/:authorIdroute to return all the articles the author has createdHow should this be manually tested?
Clone the repo, run npm install; using postman, hit the
/api/v1/authors/articles/:authorIdendpointWhat are the relevant pivotal tracker stories?
#161280586