Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161368505 prevent double password encryption on password update #48

Conversation

johngorithm
Copy link
Contributor

What does this PR do?

fix double password encryption error

Description of Task to be completed?

  • prevent password encryption when update users' password on successful password reset since the user model is already configured to do this whenever a password is to be updated.

How should this be manually tested?

  • Clone the repository.
  • Check out the bg-prevent-double-password-encryption-on-password-update-161368505 branch.
  • Run npm install on your local machine.
  • Run npm test

What are the relevant pivotal tracker stories?

#161368505

fix(authorization): fix double password encryption error

- prevent password encryption when update users' password on successful password reset since the user model is already configured to do this whenever password is to be updated.

[Delivers #161368505]
@coveralls
Copy link

Pull Request Test Coverage Report for Build 659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 93.558%

Totals Coverage Status
Change from base Build 645: -0.07%
Covered Lines: 984
Relevant Lines: 1046

💛 - Coveralls

@iAmao iAmao merged commit 29b7e0e into develop Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants