#156874253 Decode token and return User Details #26
Conversation
JoyLubega
requested review from
shemogumbe,
PatrickCmd,
owenbob,
dkam26 and
proxiex
|
I am curious, why have you included pull request template here. |
There was a problem hiding this comment.
@JoyLubega Thanks for the great work, kindly ensure checks are passing, thanks.
|
Am still working on making sure that circleci passes, Because my tests run fine on the local machine |
|
##Screenshots |
1 similar comment
|
##Screenshots |
|
Some help needed, to make circleCI pass I had to hard code the secret key in my work. CircleCI couldn't pick it from the env. |
|
@JoyLubega see @dkam26 to add that environment variable on CircleCI for the mrm project. |
|
FInally, CircleCI is Passing |
|
@PatrickCmd I have removed the print statements |
JoyLubega
force-pushed
the
ft-intergrate-andela-platform-156874253
branch
from
aaa8b60
to
3bb59af
Compare
Pull Request Test Coverage Report for Build 357
💛 - Coveralls |
JoyLubega
force-pushed
the
ft-intergrate-andela-platform-156874253
branch
from
01fe156
to
37e94ed
Compare
JoyLubega
force-pushed
the
ft-intergrate-andela-platform-156874253
branch
from
37e94ed
to
ecd52f2
Compare
|
@shemogumbe , Help me elaborate on what is unnecessary |
admin_schema.py
Outdated
| @@ -0,0 +1,21 @@ | |||
| import graphene | |||
There was a problem hiding this comment.
User model not necesary for the sake of decoding a token received from front end as part of response headers
api/user/models.py
Outdated
| @@ -0,0 +1,14 @@ | |||
| from sqlalchemy import ( | |||
There was a problem hiding this comment.
For the sake of the task 'decoding token'this model is not necesary
api/user/models.py
Outdated
| from utilities.utility import Utility | ||
|
|
||
|
|
||
| class User(Base, Utility): |
There was a problem hiding this comment.
Not necesary for the sake of decoding token
api/user/schema.py
Outdated
| return query.filter(UserModel.email == email).first() | ||
|
|
||
|
|
||
| class Mutation(graphene.ObjectType): |
There was a problem hiding this comment.
Not necesary for purposes of the task decoding token
helpers/auth/decode_token.py
Outdated
| is_admin | ||
| """ | ||
|
|
||
| def verify(self, token): |
There was a problem hiding this comment.
Makes sense, issues is, where does the token come from , does not seem like it comes from the request headers?
helpers/auth/decode_token.py
Outdated
| except jwt.InvalidTokenError: | ||
| return jsonify({ 'message': 'Invalid token. Please Provide a valid token!'}), 401 | ||
|
|
||
| def is_admin(self, token): |
There was a problem hiding this comment.
This is not necesary for now, we are not yet at the stage of permissions yet
helpers/auth/decode_token.py
Outdated
|
|
||
|
|
||
| def resolve_token(self, info): | ||
| print(info) |
There was a problem hiding this comment.
print statements should not be pushed, please remove them.
helpers/auth/decode_token.py
Outdated
| SECRET_KEY = os.getenv('SECRET_KEY') | ||
| try: | ||
| payload = jwt.decode(auth_token, verify=False) | ||
| print(payload) |
What does this PR do?
This PR decode the token and returns user's Name and email
Description of Task to be completed?
How should this be manually tested?
N/A
Any background context you want to provide?
What are the relevant Pivotal Tracker board stories?
#156874253
Screenshots (if appropriate)