#157385680 view room occupants #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoyLubega
requested review from
PatrickCmd,
shemogumbe,
owenbob,
sannytee,
proxiex and
dkam26
PatrickCmd
reviewed
Jun 12, 2018
api/room/schema.py
Outdated
| @@ -50,10 +56,15 @@ def mutate(self, info, room_id, **kwargs): | |||
|
|
|||
| class Query(graphene.ObjectType): | |||
| all_rooms = graphene.List(Room) | |||
| get_room_by_id = graphene.Field( | |||
| Room, | |||
| get_room_by_id = graphene.List( | |||
There was a problem hiding this comment.
I see you still have old work, please can you rebase with develop to have the current changes.
JoyLubega
force-pushed
the
ft-view-room-occupants-157385680
branch
from
ac70d81
to
5c5b342
Compare
Pull Request Test Coverage Report for Build 463
💛 - Coveralls |
JoyLubega
force-pushed
the
ft-view-room-occupants-157385680
branch
2 times, most recently
from
aa1a7c0
to
f42da14
Compare
JoyLubega
changed the title
JoyLubega
force-pushed
the
ft-view-room-occupants-157385680
branch
from
be68557
to
e2981e6
Compare
sannytee
reviewed
Jun 22, 2018
There was a problem hiding this comment.
@JoyLubega has this been rebased with the current changes in develop. I'm having trouble pulling the branch to test. Kindly check and confirm
proxiex
reviewed
Jun 22, 2018
JoyLubega
force-pushed
the
ft-view-room-occupants-157385680
branch
3 times, most recently
from
21fff3b
to
5531303
Compare
added 11 commits
June 27, 2018 21:12
JoyLubega
force-pushed
the
ft-view-room-occupants-157385680
branch
from
14433ea
to
f0419f2
Compare
PatrickCmd
reviewed
Jun 28, 2018
helpers/calendar/events.py
Outdated
| r"(^[a-zA-Z0-9_.+-]+@andela+\.com+$)", attendees) | ||
| if match: | ||
| all_attendees.append(attendee.get('email')) | ||
| print(all_attendees) |
There was a problem hiding this comment.
This print statement should be removed.
PatrickCmd
reviewed
Jun 28, 2018
tests/test_rooms/test_query_rooms.py
Outdated
| @@ -18,6 +18,7 @@ def test_query_rooms(self): | |||
|
|
|||
| def test_query_room_with_id(self): | |||
| query = self.client.execute(room_query_by_id) | |||
| print(room_query_by_id_response) | |||
There was a problem hiding this comment.
Working on it now
PatrickCmd
reviewed
Jun 28, 2018
api/room/models.py
Outdated
| @@ -28,3 +29,4 @@ def __init__(self, **kwargs): | |||
| self.image_url = kwargs['image_url'] | |||
| self.calendar_id = kwargs['calendar_id'] | |||
| self.floor_id = kwargs['floor_id'] | |||
| self.calendar_id = kwargs['calendar_id'] | |||
There was a problem hiding this comment.
calendar_id field is defined twice in the models
PatrickCmd
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Views all occupants in a given meeting room
screenshots
Description
N/A
Pivotal tracker story
#157385680