#158212394 Build health check url #42

dkam26 · 2018-06-14T06:46:10Z

What does this PR do?

Have a healthcheck Url to confirm db is up and running

Description of Task to be completed?

Have the endpoint below working:

GET /_healthcheck

How should this be manually tested?

After setting up the project on your locahost.

Using a web browser,test the URL.

What are the relevant pivotal tracker stories?

#158212394

Screenshots

When the database up and running.

When the database doesn't exist or down.

coveralls · 2018-06-14T06:53:29Z

Pull Request Test Coverage Report for Build 399

15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 99.167%

Totals
Change from base Build 393:	0.04%
Covered Lines:	357
Relevant Lines:	360

💛 - Coveralls

PatrickCmd · 2018-06-14T07:00:28Z

Readme.md

@@ -58,7 +58,7 @@
        ```
 - Run application.
    ```
-    python manage.py runserver
+


Why is manage command for starting server removed from the readme?

@PatrickCmd ,Thank you.It was a typo.Let me fix it

PatrickCmd · 2018-06-14T07:13:01Z

app.py

+            schema=healthcheck_schema,
+            graphiql=True   # for healthchecks
+        )
+    )


I thought the health check url would be a template for visualization if the services are okay but not an endpoint. What I mean by this, is having a route for a view function that renders this template.

@PatrickCmd ,the story description was changed to an endpoint.

PatrickCmd · 2018-06-14T07:20:55Z

healthcheck_schema.py

+        return res
+
+
+healthcheck_schema = graphene.Schema(query=Query)


I think what should be in this module must look like what is in the main.py module.

@PatrickCmd ,I dont get what you saying.Please rephrase your feedback.

…dela/mrm_api into ft-health-check-url-158212394

PatrickCmd · 2018-06-14T08:26:16Z

requirements.txt

-coveralls
+urllib3==1.23
+virtualenv==15.2.0
+Werkzeug==0.14.1


@dkam26 Your requirements file is not following the best practice we decided as the backend team. Please take a review at the one on develop.

fidelisojeah · 2018-06-14T12:04:49Z

@dkam26 for this health check

Can you show the what the expected output is supposed to be if successful and if unsuccessful (in your PR request)

fidelisojeah · 2018-06-14T12:07:01Z

app.py

@@ -23,6 +24,14 @@ def create_app(config_name):
            graphiql=True   # for having the GraphiQL interface
        )
    )
+    app.add_url_rule(
+        '/_healthcheck',
+        view_func=GraphQLView.as_view(


Not sure this healthcheck has to be a graphQL element
a regular endpoint with a JSON kind of response is fine (Though the graphQL one is also okay).

@fidelisojeah ,All is done

* Add untracked files after merge * [Fix] Pull Updated changes to develop * [Feature #158429512] Add Delete room functionality This PR adds the delete room functionality where a user can delete a room once they have the correct roomId.This commit also containes tests for this feature.

* [Bug 158140748] Restrict deletion of room resources to admin [Bug 158140748] Add location for backward relationship [Bug 158140748] Add block for backward relationship [Bug 158140748] Add floor for backward relationship [Bug 158140748] Add room for backward relationship [Bug 158140748] Add decorator function to restrict mutation for admins [Bug 158140748] Add location field on saving [Bug 158140748] Add decorator and save functions * [Bug 158140748] Correct flake8 errors * [Bug 158140748] Correct failing test * [Bug 158140748] Increase test coverage * [Bug 158140748] Resolve merge conflicts * [Bug 158140748] Resolve merge conflicts

add maintainability badge from code-climate to readme add test-coverage badge from code-climate to readme add more jobs to config.yml file [Finishes #158227258]

…dela/mrm_api into ft-health-check-url-158212394

* [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Fix flake8 errors * #158429512 Delete a room (#44) * Add untracked files after merge * [Fix] Pull Updated changes to develop * [Feature #158429512] Add Delete room functionality This PR adds the delete room functionality where a user can delete a room once they have the correct roomId.This commit also containes tests for this feature. * #158140748 Restrict room resource deletion (#43) * [Bug 158140748] Restrict deletion of room resources to admin [Bug 158140748] Add location for backward relationship [Bug 158140748] Add block for backward relationship [Bug 158140748] Add floor for backward relationship [Bug 158140748] Add room for backward relationship [Bug 158140748] Add decorator function to restrict mutation for admins [Bug 158140748] Add location field on saving [Bug 158140748] Add decorator and save functions * [Bug 158140748] Correct flake8 errors * [Bug 158140748] Correct failing test * [Bug 158140748] Increase test coverage * [Bug 158140748] Resolve merge conflicts * [Bug 158140748] Resolve merge conflicts * chore(code-climate): integrate code-climate with backend (#47) add maintainability badge from code-climate to readme add test-coverage badge from code-climate to readme add more jobs to config.yml file [Finishes #158227258] * [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Fix flake8 errors * [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Fix flake8 errors * [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Fix flake8 errors * [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in UpdateRoom mutation * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Include calendarId in update room mutation test * [Bug #158463674] Fix flake8 errors * [Bug #158463674] Fix flake8 errors * [Bug 158463674] Rebase with develop * [Bug 158463674] Rebase with develop * [Bug 158463674] Refactor schema.py file * [Bug bg-include-calendar-id-158463674] Add condition for non existant room

- add a helper method to get user_id from database - implement the mutation class `DeleteUser` to handle deleting user - provide relevant user mutation to graphene schema

daddychukz

LGTM

- add token to perform default user operations - create fixtures to perform deleteUser mutation - create an admin user in the base test - write test cases for deleting user - refactor deleteResource test to reflect changes in base test

#157912656 Admin can delete a user

proxiex

Everything looks good except for the alembic/versions folder, there are way too many of the versions and a lot of them doing nothing. I suggest you get rid of them

JoyLubega · 2018-06-29T09:25:45Z

@dkam26 Please Remove the Migrations files in The versions folder. If some thing changed in the models, i would advise you add it in the the migration file on develop."initial migration

JoyLubega

Good Work @dkam26

Deo Kamara added 4 commits June 11, 2018 11:48

[Feature #158212394] healthcheck url setup

d126513

[Feature #158212394] healthcheck url setup

0da4dba

[Feature #158212394] Postgres status

72778c9

[Feature #158212394] Test healthcheck url

a93df60

dkam26 requested review from fidelisojeah and daddychukz June 14, 2018 06:46

Merge branch 'develop' into ft-health-check-url-158212394

67f2fca

PatrickCmd reviewed Jun 14, 2018

View reviewed changes

Deo Kamara added 2 commits June 14, 2018 10:39

[Feature #158212394] Edit readme

40bd926

Merge branch 'ft-health-check-url-158212394' of https://github.com/an…

5f2f147

…dela/mrm_api into ft-health-check-url-158212394

PatrickCmd reviewed Jun 14, 2018

View reviewed changes

[Feature #158212394] Edit requirements.txt

2390bbf

fidelisojeah reviewed Jun 14, 2018

View reviewed changes

Walukagga Patrick and others added 13 commits June 14, 2018 17:50

[Bug 158326634] Enable backward relationship (#41)

162b9e1

chore(code-climate): integrate code-climate with backend (#47)

6e7362f

add maintainability badge from code-climate to readme add test-coverage badge from code-climate to readme add more jobs to config.yml file [Finishes #158227258]

[Feature #158212394] healthcheck url setup

36d010e

[Feature #158212394] healthcheck url setup

d717396

[Feature #158212394] Postgres status

8c5c037

[Feature #158212394] Test healthcheck url

e12bcd4

[Feature #158212394] Edit readme

56f9516

[Feature #158212394] Edit requirements.txt

306665b

Merge branch 'ft-health-check-url-158212394' of https://github.com/an…

4ccea45

…dela/mrm_api into ft-health-check-url-158212394

[Feature 158212394] Rebase with develop

03bb497

proxiex requested a review from daddychukz June 28, 2018 12:06

[feature #157912656] Admin can delete a user

2b70495

- add a helper method to get user_id from database - implement the mutation class `DeleteUser` to handle deleting user - provide relevant user mutation to graphene schema

daddychukz approved these changes Jun 28, 2018

View reviewed changes

sannytee and others added 18 commits June 28, 2018 17:04

Merge pull request #50 from andela/ft-delete-user-157912656

3c4d373

#157912656 Admin can delete a user

[Feature #158212394] healthcheck url setup

e916140

[Feature #158212394] healthcheck url setup

4c25bcc

[Feature #158212394] Postgres status

ff666d6

[Feature #158212394] Test healthcheck url

c3f1bee

[Feature #158212394] Edit readme

1e6657f

[Feature #158212394] Edit requirements.txt

7f746c7

[Feature #158212394] healthcheck url setup

ba84eee

[Feature #158212394] healthcheck url setup

915159e

[Feature #158212394] Postgres status

76a7d7a

[Feature #158212394] Test healthcheck url

db10c0a

[Feature #158212394] Edit readme

51d28a3

[Feature #158212394] Edit requirements.txt

7223bc2

[Feature 158212394] Rebase with develop

2d8a34d

[Feature 158212394] Rebase with develop

8039ce4

[Feature 158212394] Rebase with develop

e908ab4

[Feature 158212394] Rebase with develop

cf1a3ed

proxiex suggested changes Jun 29, 2018

View reviewed changes

[Feature 158212394] Remove migrations files

4fecab8

proxiex approved these changes Jun 29, 2018

View reviewed changes

JoyLubega approved these changes Jun 29, 2018

View reviewed changes

Include migrations file

ba29652

PatrickCmd approved these changes Jul 2, 2018

View reviewed changes

PatrickCmd merged commit 12f48c2 into develop Jul 2, 2018

shemogumbe deleted the ft-health-check-url-158212394 branch October 29, 2018 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#158212394 Build health check url #42

#158212394 Build health check url #42

dkam26 commented Jun 14, 2018 •

edited

Loading

coveralls commented Jun 14, 2018 •

edited

Loading

PatrickCmd Jun 14, 2018

dkam26 Jun 14, 2018

PatrickCmd Jun 14, 2018

dkam26 Jun 14, 2018

PatrickCmd Jun 14, 2018

dkam26 Jun 14, 2018

PatrickCmd Jun 14, 2018

fidelisojeah commented Jun 14, 2018

fidelisojeah Jun 14, 2018

dkam26 Jun 18, 2018

daddychukz left a comment

proxiex left a comment •

edited

Loading

JoyLubega commented Jun 29, 2018

JoyLubega left a comment

#158212394 Build health check url #42

#158212394 Build health check url #42

Conversation

dkam26 commented Jun 14, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots

coveralls commented Jun 14, 2018 • edited Loading

Pull Request Test Coverage Report for Build 399

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fidelisojeah commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daddychukz left a comment

Choose a reason for hiding this comment

proxiex left a comment • edited Loading

Choose a reason for hiding this comment

JoyLubega commented Jun 29, 2018

JoyLubega left a comment

Choose a reason for hiding this comment

dkam26 commented Jun 14, 2018 •

edited

Loading

coveralls commented Jun 14, 2018 •

edited

Loading

proxiex left a comment •

edited

Loading