fix: stabilize app #20
Conversation
public/js/directives.js
Outdated
| return{ | ||
| restrict: 'EA', | ||
| templateUrl: '/views/scoreboard.html', | ||
| link: function(scope, elem, attr){} |
There was a problem hiding this comment.
Expected method shorthand object-shorthand
Unexpected unnamed method 'link' func-names
Missing space before function parentheses space-before-function-paren
'attr' is defined but never used no-unused-vars
Missing space before opening brace space-before-blocks
public/js/directives.js
Outdated
| @@ -58,6 +58,12 @@ angular.module('mean.directives', []) | |||
| templateUrl: '/views/question.html', | |||
| link: function(scope, elem, attr) {} | |||
| }; | |||
| }).directive('scoreboard', function(){ | |||
| return{ | |||
There was a problem hiding this comment.
Expected space(s) after "return" keyword-spacing
public/js/directives.js
Outdated
| @@ -58,6 +58,12 @@ angular.module('mean.directives', []) | |||
| templateUrl: '/views/question.html', | |||
| link: function(scope, elem, attr) {} | |||
| }; | |||
| }).directive('scoreboard', function(){ | |||
There was a problem hiding this comment.
Expected line break before .directive newline-per-chained-call
Unexpected unnamed function func-names
Unexpected function expression prefer-arrow-callback
Missing space before function parentheses space-before-function-paren
Missing space before opening brace space-before-blocks
public/js/directives.js
Outdated
| restrict: 'EA', | ||
| templateUrl: '/views/scoreboard.html', | ||
| link: () => {} | ||
| })).directive('timer', function(){ |
There was a problem hiding this comment.
Expected line break before .directive newline-per-chained-call
Unexpected function expression prefer-arrow-callback
Unexpected unnamed function func-names
Missing space before function parentheses space-before-function-paren
Missing space before opening brace space-before-blocks
test/e2e/game.spec.js
Outdated
|
|
||
| it('should have timer component', () => { | ||
| timer = element(by.css('card-panel')).element(by.id('time')); | ||
| console.log('time', timer); |
There was a problem hiding this comment.
Unexpected console statement no-console
test/e2e/game.spec.js
Outdated
| const appRoot = 'http://localhost:3001/#!/app' | ||
| || 'http://localhost:3000/#!/app'; | ||
|
|
||
| let nav,timer; |
There was a problem hiding this comment.
A space is required after ',' comma-spacing
test/e2e/landing.spec.js
Outdated
| @@ -46,12 +48,10 @@ describe('Nazgul front-end UI', () => { | |||
| .getText()) | |||
| .toEqual('A game for horrible people desperately trying to do good'); | |||
| about = browser.findElement(by.css('h3.center.lighter-pink-text')); | |||
| aboutDescription = browser.findElement(by.css('p.lighter-pink-text')); | |||
| aboutDescription = browser.findElement(by.css('.lighter-pink-text')); | |||
There was a problem hiding this comment.
'aboutDescription' is not defined no-undef
test/e2e/game.spec.js
Outdated
| /* global browser, expect, element, by, before, */ | ||
|
|
||
| let timerCount, timerdesc, questSect, startGameBtn, endGameInfo, | ||
| showAnsCards, showHowToPlay, showCzar, showCharityWidget, gameEndInfo, showScoreboard, showCurrentPlayer, showCzarMarker; |
There was a problem hiding this comment.
Line 4 exceeds the maximum line length of 80 max-len
| }); | ||
| }); | ||
|
|
||
| it('should show "How To Play" section"', () => { |
There was a problem hiding this comment.
Duplicated. See above test
test/e2e/signup.spec.js
Outdated
| @@ -8,6 +8,10 @@ describe('Nazgul front-end UI', () => { | |||
| browser.waitForAngularEnabled(false); | |||
| }); | |||
|
|
|||
| afterAll(() => { | |||
There was a problem hiding this comment.
Does your tsk have anything to do with signup? Why are you editing the signup specs
There was a problem hiding this comment.
No, it doesn't have anything to do with signup. I was trying to debug. I have removed it.
I touched landing.spec.js because there was same id for two different divs and that caused the test to pass and fail sometimes. It was not consistent. So I told Gabriel and fixed it.
What does this PR do?
Fixes the nazgul-cfh application