Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156100323 arrange tests and add more tests #26

Merged
merged 2 commits into from
Apr 23, 2018

Conversation

Efosaok
Copy link
Contributor

@Efosaok Efosaok commented Apr 23, 2018

What does this PR do?

Refactor test file arrangements and add more tests.

Description of Task to be completed?

Arrange test suites in different files indicating what each tests are meant for

How should this be manually tested?

clone this repo
run npm install
run npm test

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#156100323

Screenshots (if appropriate)

Questions:

import supertest from 'supertest';
import { expect } from 'chai';
import mongoose from 'mongoose';
import app from '../../dist/server';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../dist/server' import/no-unresolved
Missing file extension for "../../dist/server" import/extensions

@@ -0,0 +1,105 @@
import supertest from 'supertest';
import { expect } from 'chai';
import mongoose from 'mongoose';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module 'mongoose' import/no-unresolved
Missing file extension for "mongoose" import/extensions

@@ -0,0 +1,105 @@
import supertest from 'supertest';
import { expect } from 'chai';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions

@@ -0,0 +1,105 @@
import supertest from 'supertest';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module 'supertest' import/no-unresolved
Missing file extension for "supertest" import/extensions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 326

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 78.947%

Totals Coverage Status
Change from base Build 323: 1.4%
Covered Lines: 30
Relevant Lines: 38

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 326

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 78.947%

Totals Coverage Status
Change from base Build 323: 1.4%
Covered Lines: 30
Relevant Lines: 38

💛 - Coveralls

@morekoya morekoya merged commit 7fa61a2 into develop Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants