Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156100323 Make font family consistent for all modals #32

Merged
merged 5 commits into from
Apr 27, 2018

Conversation

Efosaok
Copy link
Contributor

@Efosaok Efosaok commented Apr 26, 2018

What does this PR do?

Implement Feedback as to Font-family and modal consistensy

Description of Task to be completed?

make the fontsize of the different modals for this task consistent with the fontsize of the main app

What are the relevant pivotal tracker stories?

#156100323

screenshots

screen shot 2018-04-26 at 12 00 59 pm

@iidrees iidrees temporarily deployed to nazgul-cfh-staging-pr-32 April 26, 2018 11:02 Inactive
@coveralls
Copy link

coveralls commented Apr 26, 2018

Pull Request Test Coverage Report for Build 411

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.947%

Totals Coverage Status
Change from base Build 403: 0.0%
Covered Lines: 30
Relevant Lines: 38

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 391

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.947%

Totals Coverage Status
Change from base Build 385: 0.0%
Covered Lines: 30
Relevant Lines: 38

💛 - Coveralls

@morekoya
Copy link
Contributor

I'm not sure who I previously gave this feedback. It is not best practice to make use of inline styles in html.

@Efosaok Efosaok changed the title Feature/156100323/peer to peer invites #156100323 Make font family consistent for all modals Apr 27, 2018
@morekoya
Copy link
Contributor

I will merge for the sake of your demo. However when I mentioned that inline styles were against convention, I expected all inline styles to be removed as they only seem to occur where you did the work for the modals for the invite story.

@morekoya morekoya merged commit 8fc39ec into develop Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants