#bg-163498757 Login verification bug (#55)

andela · Jan 31, 2019 · b2fb5ab · b2fb5ab
1 parent 350262a
commit b2fb5ab
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 41 deletions.
diff --git a/server/controllers/UserController.js b/server/controllers/UserController.js
@@ -300,6 +300,16 @@ class UserController {
         });
       }
 
+      if (foundUser.dataValues.isVerified !== true) {
+        return res.status(401).send({
+          status: 'failure',
+          data: {
+            statusCode: 401,
+            message: 'Your account has not been verified'
+          }
+        });
+      }
+
       const payload = {
         userId: foundUser.id,
         userName: foundUser.userName,

diff --git a/server/migrations/.gitkeep b/server/migrations/.gitkeep
diff --git a/server/migrations/20190121154422-create-user-follows.js b/server/migrations/20190121154422-create-user-follows.js
diff --git a/server/migrations/20190127133424-create-reading-stats.js b/server/migrations/20190127133424-create-reading-stats.js
@@ -1,7 +1,6 @@
 export default {
   up: (queryInterface, Sequelize) => {
-    return queryInterface.sequelize
-      .query('CREATE EXTENSION IF NOT EXISTS "uuid-ossp";')
+    return queryInterface.sequelize.query('CREATE EXTENSION IF NOT EXISTS "uuid-ossp";')
       .then(() => {
         return queryInterface.createTable('ReadingStats', {
           id: {

diff --git a/server/seeders/20190115151310-demoUser.js b/server/seeders/20190115151310-demoUser.js
@@ -25,6 +25,7 @@ export default {
         email: 'kabir@now.com',
         bio: 'Learning life now',
         password: '$2y$10$QCQ1uW0OWH7xKOvJ9gNWsewzoXSjvAmXw21mcZBEB52TN6T/f2Xfy',
+        isVerified: true,
         authTypeId: '15745c60-7b1a-11e8-9c9c-2d42b21b1a3e',
         roleId: '3ceb546e-054d-4c1d-8860-e27c209d4ae4',
         getEmailsNotification: true,

diff --git a/server/test/controllers/comment.spec.js b/server/test/controllers/comment.spec.js
@@ -191,6 +191,7 @@ describe('Comment Model', () => {
         });
       expect(response.status).to.eqls(404);
       expect(response.body.status).to.eqls('failure');
+      expect(response.body.data.message).to.eqls('Article not found');
     });
   });
   describe('Delete comment', () => {

diff --git a/server/test/controllers/userController.spec.js b/server/test/controllers/userController.spec.js
@@ -142,11 +142,21 @@ describe('User Model', () => {
       expect(response.body.data.message).to.eqls('Sorry!!, Your login information is not correct.');
     });
 
+    it('User should get an error for unverified account', async () => {
+      const response = await chai
+        .request(app)
+        .post('/api/v1/auth/login')
+        .send({ user: userInfo.email, password: userInfo.password });
+      expect(response.status).to.eql(401);
+      expect(response.body.status).to.eqls('failure');
+      expect(response.body.data.message).to.eqls('Your account has not been verified');
+    });
+
     it('User should get loggedIn and token returned when correct credentials are provided', async () => {
       const response = await chai
         .request(app)
         .post('/api/v1/auth/login')
-        .send({ user: userInfo.userName, password: userInfo.password });
+        .send({ user: 'kabir', password: 'Blahblah' });
       expect(response.status).to.eql(200);
       expect(response.body.status).to.eqls('success');
       expect(response.body.data.token).to.be.a('String');