Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163288966 Change id types to UUIDV4 #19

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Conversation

Bobsar0
Copy link
Collaborator

@Bobsar0 Bobsar0 commented Jan 17, 2019

What does this PR do?

Change all model id's to type UUID

Description of Task to be completed?

Change all model id's from INTEGER to type UUID

How should this be manually tested?

• clone the repo
• cd into the repo
Setup development database
• run npm install
• run npm run migrate && npm run seed
• Check the id columns of the seeded users, roles and authTypes tables.

What are the relevant pivotal tracker stories?

Change id types to UUID

- Change all model id's to type uuid
@jesseinit jesseinit temporarily deployed to neon-ah-staging-pr-19 January 17, 2019 20:11 Inactive
@jesseinit jesseinit temporarily deployed to neon-ah-staging-pr-19 January 18, 2019 06:33 Inactive
Copy link
Contributor

@jesseinit jesseinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the push is building, the test passing.
This looks pretty good to me.

@Makwe-O
Copy link
Contributor

Makwe-O commented Jan 18, 2019

LGTM

…ize "uuid-ossp" extension for uuid autogeneration- Replace id defaultValue `uuidv4()` with `Sequelize.literal('uuid_generate_v4()')`
@seunkoko seunkoko merged commit 431d1c6 into dev Jan 18, 2019
@seunkoko seunkoko deleted the bg-fix-db-travis/UUID-163288966 branch January 18, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants