Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#167727316] Feature Multi City Request #42

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

shonubijerry
Copy link
Collaborator

What does this PR do?

  • Users should be able to make multi city request

Description of Task to be completed?

  • Create routes (multi-city, getAllTrips, getOneTrip)
  • Write unit test
  • Setup subRequest model and migration table and seed data
  • Create request validation middleware
  • Create controller for routes
  • Write swagger documentation

How should this be manually tested?

Any background context you want to provide?

New table SubTripRequests was created. This table has a one-to-many association with the TripRequests in that a multi-city request can have multiple sub requests inside the SubTripRequest table.

Relevant pivotal tracker stories?
#167727316

@shonubijerry shonubijerry added the review needed Review this pull request label Sep 11, 2019
src/controllers/accommodationController.js Outdated Show resolved Hide resolved
src/controllers/tripController.js Outdated Show resolved Hide resolved
src/controllers/tripController.js Show resolved Hide resolved
@shonubijerry shonubijerry force-pushed the ft-multi-city-request-167727316 branch 4 times, most recently from 49ca4e0 to 40ec61a Compare September 12, 2019 12:15
@Hector101 Hector101 merged commit 4349629 into develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed Review this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants