Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165663486 Create database models #17

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

rwajon
Copy link
Contributor

@rwajon rwajon commented Apr 28, 2019

What does this PR do?

Create database models for storing data

Description of Task to be completed?

Have the following models created:

  • User

  • Article

  • Comment

What are the relevant pivotal tracker stories?

165663486

@e-liyai
Copy link
Contributor

e-liyai commented Apr 29, 2019

@rwajon implement tests for the models created

@e-liyai e-liyai closed this Apr 29, 2019
@e-liyai e-liyai reopened this Apr 29, 2019
@rwajon
Copy link
Contributor Author

rwajon commented Apr 29, 2019

Ok, I'm gonna work on it

@e-liyai
Copy link
Contributor

e-liyai commented Apr 29, 2019

@rwajon migration files don't need tests. only the models

@rwajon rwajon force-pushed the ch-create-db-models-165663486 branch 4 times, most recently from 2ccbcec to e31c531 Compare April 29, 2019 15:09
@rwajon rwajon force-pushed the ch-create-db-models-165663486 branch from e31c531 to 0c88039 Compare April 29, 2019 15:12
@kagaramag
Copy link
Collaborator

kagaramag commented Apr 29, 2019

@e-liyai I have reviewed this PR, it contains the necessary configuration for Codeclimate and Travis-ci, what if we consider this one and close the ones raised 3 days ago, the PRs that can be closed are [#14] and [#16]. because the CI configurations there are not working but here there are okey.

Copy link
Contributor

@e-liyai e-liyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@e-liyai e-liyai merged commit 58c9147 into develop Apr 29, 2019
@e-liyai e-liyai deleted the ch-create-db-models-165663486 branch April 29, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants