#165412918 Give a rating to an article #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
7 times, most recently
from
9570bb4
to
98d8f4e
Compare
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
6 times, most recently
from
91e3e52
to
4069ffc
Compare
e-liyai
reviewed
May 30, 2019
package.json
Outdated
| @@ -32,6 +32,7 @@ | |||
| "chance": "^1.0.18", | |||
| "cheke": "^1.0.3", | |||
| "cors": "^2.8.5", | |||
| "d": "^1.0.0", | |||
There was a problem hiding this comment.
The package is no longer needed, I am removing it
src/queries/ratings/create.js
Outdated
| export default async (data = {}) => { | ||
| const { articleId, userId, rating } = data; | ||
| // check if already exist | ||
| const result = await db.Rating.findAll({ |
There was a problem hiding this comment.
there should be a file for findAll Ratings then import it here
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
3 times, most recently
from
61b6baf
to
2c39da1
Compare
e-liyai
suggested changes
May 31, 2019
src/queries/ratings/update.js
Outdated
| import db from '../../models'; | ||
|
|
||
| export default async (articleId) => { | ||
| const allRatings = await db.Rating.findAll({ |
src/models/rating.js
Outdated
| @@ -0,0 +1,63 @@ | |||
| import * as queries from '../queries'; | |||
There was a problem hiding this comment.
there should not be queries in a model file. Set static data
rwajon
approved these changes
May 31, 2019
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
3 times, most recently
from
b671fb2
to
4637946
Compare
|
@e-liyai made changes, you can check. |
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
2 times, most recently
from
87617c1
to
15cadae
Compare
|
@e-liyai check this PR is ready. |
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
from
15cadae
to
6069e02
Compare
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
from
247fe74
to
6350219
Compare
|
@e-liyai can you check this PR for me. it's ready 👍 |
sengayire
approved these changes
Jun 10, 2019
e-liyai
suggested changes
Jun 10, 2019
src/queries/ratings/create.js
Outdated
| const response = {}; | ||
| if (result && result.length === 0) { | ||
| await db.Rating.create({ rating, articleId, userId }, { logging: false }); | ||
| response.message = 'Thank you for rating this article'; |
There was a problem hiding this comment.
remove message in queries, it should be in controller
src/queries/ratings/create.js
Outdated
| { where: { [db.Op.and]: { articleId, userId } }, logging: false } | ||
| ); | ||
| response.statusCode = status.OK; | ||
| response.message = 'Your article rating has been updated'; |
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
2 times, most recently
from
b74ebf6
to
d5fe9e7
Compare
e-liyai
suggested changes
Jun 10, 2019
src/controllers/RatingController.js
Outdated
| rating: { | ||
| message: | ||
| response.statusCode === status.OK | ||
| ? 'Your article rating has been updated' |
There was a problem hiding this comment.
the logic here seems flawed if the status is ok article update successful else even in the case of an error the message displayed is Thank you for rating this article
src/queries/ratings/create.js
Outdated
| // check if already exist | ||
| const result = await findAll(articleId, userId); | ||
| const response = {}; | ||
| if (result && result.length === 0) { |
There was a problem hiding this comment.
i see a create or update scenario here, update the filename appropriately
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
2 times, most recently
from
be36ac4
to
48de0c6
Compare
kagaramag
force-pushed
the
feature/rate-article-165412918
branch
from
48de0c6
to
96a5daf
Compare
e-liyai
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Give a rating on the article written by others
Description of Task to be completed?
Have the following endpoint accessible to an authenticated user:
POST /api/v1/articles/:slug/ratinggive rating to an article identified by its slugGET /api/v1/articles/:slug/ratingGet users who rated a given articleHow should this be manually tested?
cdinto it and typenpm test->make sure you signup then login to get the access token,
->create an article,
-> Create a rating using this endoint:
/api/v1/articles/:slug/rating-> Make sure you pass the access token in the header with the following key name:
access-token,-> Finally, send a JSON object of the following structure : {"rating": 1}
Any background context you want to provide?
Given,
n: number of rating per articles: sum of ratings per a given articleWhat are the relevant pivotal tracker stories?
#165412918
Screenshots (if appropriate)
N/A
Questions:
N/A