#165412925 #165412925 #165412938 Users follow and unfollow each other. #53

sengayire · 2019-05-27T01:14:24Z

What does this PR do?

Allow Authors to follow and unfollow each other
Allow admin to register a new user
allow admin to update users access level
create CRUD endpoints for admin
send activation email after a successful registration

Description of Task to be completed?

creating the following endpoints:
POST /api/v1/users/follow
POST /api/v1/users/unfollow
GET /api/v1/users/followers
GET /api/v1/users/following

POST /api/v1/users/ to register new user
DELETE /api/v1/users/:id to delete a user
UPDATE /api/v1/users/:id to update a user information
GET /api/v1/users/ to fetch all users
GET /api/v1/users/:id to fetch a single user

1. Send activation link to the provided email to confirm registration
2. when user click to the activation link then account activated

How should this be manually tested?

clone the repo locally and user postman to test endpoints

Any background context you want to provide?

test endpoints with Mocha and Chai

What are the relevant pivotal tracker stories?

#165412925 # 165412938 #165412911

e-liyai · 2019-05-31T11:28:28Z

src/controllers/AuthLocalController.js

+   * @returns {object} it return true if account verified otherwise it return false
+   */
+  static async reset(req, res) {
+    return res.status(status.OK).send({


i thought the reset link is sent via email

yes the reset link sent via email, I added this controller to return the message when user click on link

e-liyai · 2019-05-31T11:30:41Z

src/helpers/isActiveUser.js

+    if (checkUser.isActive) {
+      return true;
+    }
+    return false;


remove this return

you mean to remove return false or all of them

e-liyai · 2019-06-06T17:08:54Z

package.json

    "scss": "npm-sass templates/sass/style.scss templates/css/style.css",
    "db:migrate": "./node_modules/.bin/sequelize db:migrate",
-    "db:migrate:seed": "./node_modules/.bin/sequelize db:seed:all",
+    "db:seed": "./node_modules/.bin/sequelize db:seed --seed 20190605075225-permissions",


why is the seeding done form one file?

the only thing that we need to seed for now is permissions, but we can still add other seed when they are needed

let's just have it as seed all and remove other seeder files.

e-liyai · 2019-06-06T17:09:04Z

package.json

@@ -7,11 +7,11 @@
    "test": "NODE_ENV=test sequelize db:migrate:undo:all && npm run db:migrate:test && npm run db:migrate:seed:test && NODE_ENV=test nyc mocha --require @babel/register --timeout 30000 src/tests/index.js",
    "cover": "npm test && nyc report --reporter=text-lcov | coveralls",
    "coveralls": "cat coverage/lcov.info | coveralls",
-    "start": "npm run db:migrate && babel-node src/index.js",
-    "dev": "nodemon src/index.js --exec babel-node --presets @babel/preset-env",
+    "start": "concurrently \"npm run db:migrate && npm run db:seed\" \"babel-node src/index.js\"",


Do we need this?

yes we need these because we need to run multiple commands concurrently and skip other when failing

e-liyai · 2019-06-06T17:26:40Z

src/controllers/AuthLocalController.js

+   * @param {object} res
+   * @returns {object} it return true if account verified otherwise it return false
+   */
+  static async reset(req, res) {


the token should be sent to user email

yes the token sent to the user email however, I added this function to return it on the body I can remove it

shouldn't be returned. Just send email.

e-liyai · 2019-06-06T17:28:43Z

src/controllers/AuthLocalController.js

+   * @param {object} res server response
+   * @returns {object} true
+   */
+  static async follow(req, res) {


why is the follow functionality under auth controller.

ok I am going to migrate it to user controller

resolved, know the follow's functionality is located to the user file

e-liyai · 2019-06-06T17:33:23Z

src/controllers/AuthLocalController.js

+        followers: followers.map(follower => delete follower.get().followedUser && follower)
+      })
+      : res.status(status.NOT_FOUND).json({
+        errors: { follows: 'You do not have followers for know' }


typeo. Just have it as you don't have followers

e-liyai · 2019-06-06T17:34:23Z

src/controllers/AuthLocalController.js

+    return followers.length
+      ? res.status(status.OK).json({
+        message: 'Followers',
+        followers: followers.map(follower => delete follower.get().followedUser && follower)


why are we deleting?

I remove the followed user here because I wont to display only the user that follows me in this controller and in the model I get both followers and following

e-liyai · 2019-06-06T17:37:46Z

src/controllers/UserController.js

-    const role = 'normal';
-    const findAll = await User.getAllUser({ role });
+  static async getAll(req, res) {
+    const role = req.user.role === 'normal' ? 'normal' : null;


I don't think we should have the role check here. we have to keep them in a helper file

e-liyai · 2019-06-06T17:44:40Z

templates/html/follow.html

+
+          switch (verb) {
+            case 'PATCH':
+              console.log(URL);


remove console

e-liyai · 2019-06-07T11:58:47Z

src/controllers/UserController.js

+   * @return {object} return all users in database
+   */
+  static async getAll(req, res) {
+    const [offset, limit] = [req.query.offset || 0, req.query.limit || 20];


these lines are not covered in tests

sengayire changed the title ~~Merge pull request #36 from andela/feature/paginating-articles-165412928~~ #165412925 Users follow and unfollow each other May 27, 2019

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 12 times, most recently from 8d90064 to 51c68f9 Compare May 29, 2019 14:05

sengayire changed the title ~~#165412925 Users follow and unfollow each other~~ #165412925 #165412925 #165412938 Users follow and unfollow each other. May 29, 2019

sengayire requested review from rwajon and denislohan May 31, 2019 11:00

e-liyai reviewed May 31, 2019

View reviewed changes

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 13 times, most recently from 40216c9 to e374415 Compare June 6, 2019 11:14

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 2 times, most recently from 69f3b28 to 6f46aa0 Compare June 6, 2019 12:24

sengayire assigned luc-tuyishime and unassigned luc-tuyishime Jun 6, 2019

sengayire requested a review from luc-tuyishime June 6, 2019 13:50

rwajon approved these changes Jun 6, 2019

View reviewed changes

luc-tuyishime approved these changes Jun 6, 2019

View reviewed changes

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 6 times, most recently from de51da0 to 30b2b35 Compare June 6, 2019 16:19

e-liyai suggested changes Jun 6, 2019

View reviewed changes

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 2 times, most recently from 2aca6c4 to 5989bbc Compare June 7, 2019 11:50

e-liyai reviewed Jun 7, 2019

View reviewed changes

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 2 times, most recently from 3d3753a to 4e7181d Compare June 7, 2019 12:53

e-liyai approved these changes Jun 7, 2019

View reviewed changes

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch 3 times, most recently from a413ecc to 8bf2e68 Compare June 10, 2019 09:56

sengayire added 2 commits June 10, 2019 13:29

Rename userController.test.js to UserController.test.js

e4581d4

[Feature #165412925] user should follow each other

0961e22

sengayire force-pushed the ft-Users-follow-unfollow-165412925 branch from 8bf2e68 to 0961e22 Compare June 10, 2019 11:36

e-liyai merged commit 1885c3a into develop Jun 10, 2019

e-liyai deleted the ft-Users-follow-unfollow-165412925 branch June 10, 2019 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#165412925 #165412925 #165412938 Users follow and unfollow each other. #53

#165412925 #165412925 #165412938 Users follow and unfollow each other. #53

sengayire commented May 27, 2019 •

edited

Loading

e-liyai May 31, 2019

sengayire May 31, 2019

sengayire Jun 6, 2019

e-liyai May 31, 2019

sengayire May 31, 2019

sengayire Jun 7, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

e-liyai Jun 7, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019 •

edited

Loading

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

e-liyai Jun 7, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

sengayire Jun 7, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

e-liyai Jun 6, 2019

e-liyai Jun 6, 2019

sengayire Jun 7, 2019

e-liyai Jun 7, 2019

sengayire Jun 7, 2019

#165412925 #165412925 #165412938 Users follow and unfollow each other. #53

#165412925 #165412925 #165412938 Users follow and unfollow each other. #53

Conversation

sengayire commented May 27, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sengayire Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sengayire commented May 27, 2019 •

edited

Loading

sengayire Jun 7, 2019 •

edited

Loading