[ft-165412937] add reading stats #68

luc-tuyishime · 2019-06-07T10:38:51Z

What does this PR do?

Have CREATE and GET on resource endpoint in express REST API

Description of Task to be completed?

Have the following endpoints working

CREATE api/v1/user/:articleSlug/stats
PATCH api/v1/user/profile/stats

How should this be manually tested?

It should be tested using POSTMAN

Any background context you want to provide?

None

What are the relevant pivotal tracker stories?

(#165412937)[https://www.pivotaltracker.com/story/show/165412937]

Screenshots (if appropriate)

None

Questions:

e-liyai · 2019-06-07T11:59:33Z

src/controllers/ArticleController.js

    const { tagList } = req.body;
    const newArticle = await Article.create({
      userId: req.user.id || 0,
      slug: helpers.generator.slug(req.body.title),
      title: req.body.title.trim(),
      description: req.body.description.trim(),
      body: req.body.body.trim(),
-      coverUrl: image.image.original,
+      // coverUrl: image.image.original,


remove commented lines

This was already removed

e-liyai · 2019-06-07T11:59:44Z

src/controllers/ArticleController.js

    const { tagList } = req.body;
    const newArticle = await Article.create({
      userId: req.user.id || 0,
      slug: helpers.generator.slug(req.body.title),
      title: req.body.title.trim(),
      description: req.body.description.trim(),
      body: req.body.body.trim(),
-      coverUrl: image.image.original,
+      // coverUrl: image.image.original,
+      coverUrl: req.body.coverUrl || 'placeholder.png',


remove placeholder

This too was already removed

e-liyai · 2019-06-07T12:02:39Z

src/controllers/UserController.js

@@ -1,5 +1,5 @@
 import dotenv from 'dotenv';
-import { User } from '../queries';
+import { User, findAndCountAll, create } from '../queries';


what does findAndCountAll query?

findAndCountAll return both data and total count.

count for what? it should be named appropriately

I have renamed to an appropriate name.

e-liyai · 2019-06-10T14:20:01Z

src/controllers/UserController.js

@@ -1,5 +1,5 @@
 import dotenv from 'dotenv';
-import { User } from '../queries';
+import { User, findAndCountAll, create } from '../queries';


count for what? it should be named appropriately

e-liyai · 2019-06-10T18:02:24Z

src/controllers/UserController.js

@@ -1,5 +1,5 @@
 import dotenv from 'dotenv';
-import { User } from '../queries';
+import { User, getAll, create } from '../queries';


this should be something like getAllRatings, use the object approach. Have an object ReadingStat and inside that have all the methods you want. That way you can name them the way you have it above. getAll and Create. This makes it easier to read and use. You will import the ReadingStat object and anywhere you want to use it you will invoke ReadingStat.create or ReadingStat.getAll

luc-tuyishime requested a review from rwajon June 7, 2019 10:40

luc-tuyishime force-pushed the feature/be-reading-stats-165412937 branch 3 times, most recently from 91ad001 to ad749b2 Compare June 7, 2019 15:08

rwajon approved these changes Jun 10, 2019

View reviewed changes

e-liyai suggested changes Jun 10, 2019

View reviewed changes

luc-tuyishime force-pushed the feature/be-reading-stats-165412937 branch 2 times, most recently from e1a232e to a087945 Compare June 10, 2019 13:29

e-liyai suggested changes Jun 10, 2019

View reviewed changes

luc-tuyishime force-pushed the feature/be-reading-stats-165412937 branch from a087945 to 4711a44 Compare June 10, 2019 14:33

e-liyai suggested changes Jun 10, 2019

View reviewed changes

luc-tuyishime force-pushed the feature/be-reading-stats-165412937 branch 5 times, most recently from 0116e0f to 83e81b8 Compare June 11, 2019 08:07

[ft-165412937] add reading stats

e98563e

luc-tuyishime force-pushed the feature/be-reading-stats-165412937 branch from 83e81b8 to e98563e Compare June 11, 2019 12:05

e-liyai approved these changes Jun 11, 2019

View reviewed changes

e-liyai merged commit e6b053b into develop Jun 11, 2019

e-liyai deleted the feature/be-reading-stats-165412937 branch June 11, 2019 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ft-165412937] add reading stats #68

[ft-165412937] add reading stats #68

luc-tuyishime commented Jun 7, 2019 •

edited

Loading

e-liyai Jun 7, 2019

luc-tuyishime Jun 10, 2019 •

edited

Loading

e-liyai Jun 7, 2019

luc-tuyishime Jun 10, 2019 •

edited

Loading

e-liyai Jun 7, 2019

luc-tuyishime Jun 10, 2019

e-liyai Jun 10, 2019

luc-tuyishime Jun 10, 2019

e-liyai Jun 10, 2019

e-liyai Jun 10, 2019

luc-tuyishime Jun 11, 2019

[ft-165412937] add reading stats #68

[ft-165412937] add reading stats #68

Conversation

luc-tuyishime commented Jun 7, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

Choose a reason for hiding this comment

luc-tuyishime Jun 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luc-tuyishime Jun 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luc-tuyishime commented Jun 7, 2019 •

edited

Loading

luc-tuyishime Jun 10, 2019 •

edited

Loading

luc-tuyishime Jun 10, 2019 •

edited

Loading