#165412889 & #165412878 Add article rating and article read time #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -80,12 +87,13 @@ export class PreviewArticle extends Component { | |||
| }; | |||
|
|
|||
| render() { | |||
| const { message } = this.props; | |||
| const { message, loading } = this.props; | |||
There was a problem hiding this comment.
'loading' is missing in props validation react/prop-types
MBenedicte
suggested changes
Jul 18, 2019
| import configureMockStore from 'redux-mock-store'; | ||
| import thunk from 'react-thunk'; | ||
| import { Provider } from 'react-redux'; | ||
| // import article from '../../../__mocks__/article'; |
| const result = createRate(rating)(dispatch); | ||
| expect(result).toHaveProperty('type'); | ||
| expect(result).toHaveProperty('payload'); | ||
| // expect(result.payload).toEqual(rating); |
| // import article from '../../__mocks__/article'; | ||
| // import message from '../../__mocks__/articleMessage'; | ||
| // import errors from '../../__mocks__/errors'; | ||
|
|
There was a problem hiding this comment.
Please make sure that all comments are removed
kagaramag
force-pushed
the
ft-rating-readtime-165412878
branch
from
03870b9
to
b837925
Compare
| faTrash, | ||
| faPen, | ||
| faTimesCircle, | ||
| faCircle, |
There was a problem hiding this comment.
'faCircle' is defined but never used no-unused-vars
| import { | ||
| faTrash, | ||
| faPen, | ||
| faTimesCircle, |
There was a problem hiding this comment.
'faTimesCircle' is defined but never used no-unused-vars
| import PropTypes from 'prop-types'; | ||
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | ||
| import { | ||
| faTrash, |
There was a problem hiding this comment.
'faTrash' is defined but never used no-unused-vars
kagaramag
force-pushed
the
ft-rating-readtime-165412878
branch
4 times, most recently
from
9a9a18b
to
4148a9e
Compare
sengayire
approved these changes
Jul 19, 2019
sengayire
approved these changes
Jul 19, 2019
kagaramag
force-pushed
the
ft-rating-readtime-165412878
branch
from
4148a9e
to
b7a3540
Compare
MBenedicte
approved these changes
Jul 19, 2019
kagaramag
force-pushed
the
ft-rating-readtime-165412878
branch
from
b7a3540
to
8eddf16
Compare
sengayire
pushed a commit
that referenced
this pull request
Jul 19, 2019
#165412889 & #165412878 Add article rating and article read time
sengayire
pushed a commit
that referenced
this pull request
Jul 19, 2019
#165412889 & #165412878 Add article rating and article read time
sengayire
pushed a commit
that referenced
this pull request
Jul 19, 2019
#165412889 & #165412878 Add article rating and article read time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
After cloning the repo,
runthe commandnpm run dev, and navigate to an article of your choice from the home pageAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#165412889
#165412878
Screenshots (if appropriate)
Questions: