Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ch setup redux 165412865 #5

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Ch setup redux 165412865 #5

merged 1 commit into from
Jun 25, 2019

Conversation

MBenedicte
Copy link
Contributor

What does this PR do?

Set up redux

hound[bot]
hound bot reviewed Jun 25, 2019
View reviewed changes
src/store/initialState.js Outdated
@@ -0,0 +1 @@
module.exports= {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

src/store/index.js
const hostname = window.location.hostname;
const isLocal = hostname === 'localhost' || hostname === '127.0.0.1';

export default createStore(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

src/store/index.js
import reducers from '../reducers';

const hostname = window.location.hostname;
const isLocal = hostname === 'localhost' || hostname === '127.0.0.1';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

src/store/index.js
import initialState from './initialState';
import reducers from '../reducers';

const hostname = window.location.hostname;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

src/store/index.js
import { composeWithDevTools } from 'redux-devtools-extension';
import thunk from 'redux-thunk';
import initialState from './initialState';
import reducers from '../reducers';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

src/serviceWorker.js Outdated
});
}

export function unregister() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

src/serviceWorker.js Outdated
registerValidSW(swUrl, config);
}
})
.catch(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

src/serviceWorker.js Outdated
) {
// No service worker found. Probably a different app. Reload the page.
navigator.serviceWorker.ready.then(registration => {
registration.unregister().then(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

src/serviceWorker.js Outdated
(contentType != null && contentType.indexOf('javascript') === -1)
) {
// No service worker found. Probably a different app. Reload the page.
navigator.serviceWorker.ready.then(registration => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

src/serviceWorker.js Outdated
fetch(swUrl)
.then(response => {
// Ensure service worker exists, and that we really are getting a JS file.
const contentType = response.headers.get('content-type');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound[bot]
hound bot reviewed Jun 25, 2019
View reviewed changes
src/reducers/index.js
@@ -0,0 +1,2 @@
const reducers = {};
export default reducers;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

src/reducers/index.js
@@ -0,0 +1,2 @@
const reducers = {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

src/index.js
ReactDOM.render(<App />, document.getElementById('root'));
ReactDOM.render(
<Provider>
<App />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected an identifier and instead saw '<'.
Unrecoverable syntax error. (52% scanned).

src/index.js

ReactDOM.render(<App />, document.getElementById('root'));
ReactDOM.render(
<Provider>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected ')' and instead saw 'Provider'.
Expected an identifier and instead saw '<'.

src/index.js
@@ -3,8 +3,14 @@ import ReactDOM from 'react-dom';
import './index.css';
import App from './components/App';
import * as serviceWorker from './serviceWorker';
import { Provider } from 'react-redux';

This comment was marked as outdated.

Sign in to view

@e-liyai e-liyai merged commit 715da3b into develop Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

@e-liyai e-liyai e-liyai approved these changes

@rwajon rwajon Awaiting requested review from rwajon

@kagaramag kagaramag Awaiting requested review from kagaramag

@luc-tuyishime luc-tuyishime Awaiting requested review from luc-tuyishime

@sengayire sengayire Awaiting requested review from sengayire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MBenedicte @e-liyai