Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167727461 Users Can Make Multi City Request #49

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

G-Chilie
Copy link
Collaborator

@G-Chilie G-Chilie commented Sep 5, 2019

What does this PR do?

This allows users to make multi-city trip requests.

How should this be manually tested?

  • Clone the branch to your local repository
  • Run npm install to install node packages
  • Using any API testing tool (eg postman, insomnia) make a POST request to the localhost:3000/api/v1/request/multi-city
category:  multi-city   // must be multi-city
origin: {string}
destination: [array]
departure_date: {string}   // e.g. 02-02-2020
return_date: {string}   // e.g. 03-05-2021
reason: {string}
room_id: {integer}

Any background context you want to provide?

This route is protected, so you need to be logged in to call it. The token will be pulled from
Authorization: <token>. Make sure to add it there. To make a request, you need a valid room_id.

What are the relevant pivotal tracker stories?

#167727461

@okoroemeka okoroemeka temporarily deployed to north-star-backend-app-pr-49 September 5, 2019 14:43 Inactive
@G-Chilie G-Chilie changed the title #167727461 (Multi City Request):Users Can Make Multi City Request #167727461 Users Can Make Multi City Request Sep 5, 2019
@G-Chilie G-Chilie added the In review In review label Sep 5, 2019
@G-Chilie G-Chilie requested review from danndav and O-Osahon and removed request for danndav September 5, 2019 20:37
Copy link
Collaborator

@O-Osahon O-Osahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything runs well. Great job

@G-Chilie G-Chilie added the Reviewed Reviewed label Sep 6, 2019
@G-Chilie G-Chilie requested review from O-Osahon and removed request for oleesir and danndav September 6, 2019 06:41
Copy link
Collaborator

@O-Osahon O-Osahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Everything works well.

@G-Chilie G-Chilie removed the In review In review label Sep 6, 2019
@okoroemeka okoroemeka merged commit 5ab1df3 into develop Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants