Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166816104 Implement User Update profile feature #15

Merged
merged 30 commits into from
Jul 9, 2019

Conversation

fxola
Copy link
Contributor

@fxola fxola commented Jul 4, 2019

What does this PR do?

  • Implement User Update profile feature

Description of Task to be completed?

  • write migration files to add columns for bio,twitterHandle and facebookHandle
  • write service method to find user by id
  • write service method to find user by username
  • write controller logic to handle user profile update
  • write middleware file to parse file(image) input
  • write middlware file for profile update validation
  • write image helper file to handle image upload to cloudinary
  • update auth route to accomodate new route
  • write unit tests for profile update feature
  • delivers[#166816104]

How should this be manually tested?

  • Clone the repository using git clone https://github.com/andela/persephone-ah-backend.git . in your terminal
  • run npm install on your terminal
  • run npm run start to start up the server
  • run npm test to see test results

Any background context you want to provide?

-N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

  • N/A

Questions:

  • N/A

Damilola Adekoya and others added 21 commits June 28, 2019 19:30
Install express validator
create a user validator file
[#166816100]
Fixing the validation methods
[#166816100]
- write migration files to add columns for bio,twitterHandle and facebookHandle
- write service method to find user by id
- write service method to find user by username
- write controller logic to handle user profile update
- write middleware file to parse file(image) input
- write middlware file for profile update validation
- write image helper file to handle image upload to cloudinary
- update auth route to accomodate new route
- write unit tests for profile update feature
- delivers[#166816104]
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/models/user.spec.js Show resolved Hide resolved
src/tests/models/user.spec.js Show resolved Hide resolved
src/tests/models/user.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
@dharmykoya
Copy link
Contributor

Looks good to me

Copy link
Contributor

@halimahO halimahO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devPinheiro devPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Outdated Show resolved Hide resolved
@fxola fxola temporarily deployed to persephone-backend-staging July 5, 2019 07:49 Inactive
src/tests/misc/index.spec.js Outdated Show resolved Hide resolved
src/tests/misc/index.spec.js Outdated Show resolved Hide resolved
src/tests/misc/index.spec.js Outdated Show resolved Hide resolved
src/tests/index.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/controllers/auth.controllers.js Outdated Show resolved Hide resolved
src/helpers/image.helper.js Outdated Show resolved Hide resolved
src/middlewares/imageUpload.middleware.js Outdated Show resolved Hide resolved
src/routes/v1/index.js Outdated Show resolved Hide resolved
src/services/auth.service.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
@fxola fxola force-pushed the ft-user-create-profile-166816104 branch from abd03de to 58e3bc8 Compare July 8, 2019 13:03
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/middleware/auth.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
@fxola fxola force-pushed the ft-user-create-profile-166816104 branch from 58e3bc8 to 56ca4c4 Compare July 8, 2019 13:05
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/validators/user.validator.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
@fxola fxola force-pushed the ft-user-create-profile-166816104 branch from 56ca4c4 to 4d59526 Compare July 8, 2019 13:13
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/utils/db.utils.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/user.spec.js Outdated Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
src/tests/controller/auth.spec.js Show resolved Hide resolved
@fxola fxola force-pushed the ft-user-create-profile-166816104 branch from 91d151f to 1cc9b13 Compare July 8, 2019 14:27
src/helpers/image.helper.js Show resolved Hide resolved
src/helpers/image.helper.js Show resolved Hide resolved
src/helpers/image.helper.js Show resolved Hide resolved
src/db/migrations/add-bio.js Show resolved Hide resolved
src/db/migrations/add-bio.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/routes/v1/auth.route.js Show resolved Hide resolved
src/routes/v1/auth.route.js Show resolved Hide resolved
src/routes/v1/auth.route.js Show resolved Hide resolved
@nedemenang nedemenang merged commit 4fb41e4 into develop Jul 9, 2019
devPinheiro pushed a commit that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants