-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166816104 Implement User Update profile feature #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install express validator create a user validator file [#166816100]
…ithub.com/andela/persephone-ah-backend into ft-user-registration-validation-166816100
…ithub.com/andela/persephone-ah-backend into ft-user-registration-validation-166816100
Fixing the validation methods [#166816100]
- write migration files to add columns for bio,twitterHandle and facebookHandle - write service method to find user by id - write service method to find user by username - write controller logic to handle user profile update - write middleware file to parse file(image) input - write middlware file for profile update validation - write image helper file to handle image upload to cloudinary - update auth route to accomodate new route - write unit tests for profile update feature - delivers[#166816104]
Looks good to me |
halimahO
reviewed
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
devPinheiro
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nedemenang
suggested changes
Jul 8, 2019
abd03de
to
58e3bc8
Compare
58e3bc8
to
56ca4c4
Compare
56ca4c4
to
4d59526
Compare
91d151f
to
1cc9b13
Compare
nedemenang
approved these changes
Jul 9, 2019
tunedev
pushed a commit
that referenced
this pull request
Jul 9, 2019
devPinheiro
pushed a commit
that referenced
this pull request
Jul 10, 2019
add jsdoc create verify function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
git clone https://github.com/andela/persephone-ah-backend.git .
in your terminalnpm install
on your terminalnpm run start
to start up the servernpm test
to see test resultsAny background context you want to provide?
-N/A
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: