Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166816124 Super admin create users #16

Closed
wants to merge 17 commits into from

Conversation

dharmykoya
Copy link
Contributor

@dharmykoya dharmykoya commented Jul 4, 2019

What does this PR do?

Allow super admin create users

Description of Task to be completed?

  • To write Test for all the functions
  • To add validations to the user model
  • To create a super admin seed file
  • To allow super admin create users
  • To allow super admin and admin update, users
  • To allow super admin and admin delete users
  • To install husky

How should this be manually tested?

N/A

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

166816124

Screenshots (if appropriate)

N/A

Questions:

N/A

devPinheiro and others added 8 commits July 3, 2019 08:17
wirte mock tests
add middleware tests
create methods to check for admin role
create method to check for super admin role
[Finishes #166816126]
wirte mock tests
add middleware tests
create methods to check for admin role
create method to check for super admin role
[Finishes #166816126]
To allow super admin create admins
To allow super admin and admin update users
To allow super admin and admin delete users
To install husky
To configure pre commit hooks
[#166816124]
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/routes/v1/user.route.js Show resolved Hide resolved
src/routes/v1/user.route.js Show resolved Hide resolved
src/routes/v1/user.route.js Show resolved Hide resolved
src/routes/v1/user.route.js Show resolved Hide resolved
src/routes/v1/user.route.js Show resolved Hide resolved
Copy link
Contributor

@devPinheiro devPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I would like you to fix the failing build on Travis.

@fxola
Copy link
Contributor

fxola commented Jul 4, 2019

Nice work dammy. Just like Sam said, look into your failing build please

tunedev and others added 2 commits July 4, 2019 10:56
> - add forget password route to send reset link
> - add password reset to carry out password reset
> - add authentication to affirm user request authenticity

[Finishes #166816102]
To configure pre commit hooks
[#166816124]
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/misc/index.spec.js Show resolved Hide resolved
src/tests/misc/index.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/middleware/auth.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
nedemenang and others added 7 commits July 4, 2019 11:26
wirte mock tests
add middleware tests
create methods to check for admin role
create method to check for super admin role
[Finishes #166816126]
…6126

#166816126 role based access control
Implementing pre commit hooks
[#166816124]
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/validators/user.validator.js Show resolved Hide resolved
src/tests/utils/db.utils.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
src/tests/controller/user.spec.js Show resolved Hide resolved
@dharmykoya
Copy link
Contributor Author

Good job! I would like you to fix your failing build on Travis.

Done already

@dharmykoya
Copy link
Contributor Author

Nice work dammy. Just like Sam said, look into your failing build please

done that already, thanks

@dharmykoya dharmykoya closed this Jul 5, 2019
@dharmykoya dharmykoya deleted the ft-admin-create-user-166816124 branch July 5, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants