-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#167737949 fix search by tag's response #46
Conversation
> - fix response of tag query to include authors details for easy card details [Finishes #167737949]
@@ -307,7 +308,8 @@ describe('Search And Filter Tests', () => { | |||
'readTime', | |||
'image', | |||
'tags', | |||
'viewsCount' | |||
'viewsCount', | |||
'author' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace 'author'
with "author"
prettier/prettier
@@ -307,7 +308,8 @@ describe('Search And Filter Tests', () => { | |||
'readTime', | |||
'image', | |||
'tags', | |||
'viewsCount' | |||
'viewsCount', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace 'viewsCount'
with "viewsCount"
prettier/prettier
@@ -86,6 +86,7 @@ describe('Search And Filter Tests', () => { | |||
'readTime', | |||
'image', | |||
'viewsCount', | |||
'author', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace 'author'
with "author"
prettier/prettier
{ | ||
model: User, | ||
as: 'author', | ||
attributes: ['firstName', 'lastName', 'image', 'email', 'userName'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace 'firstName',·'lastName',·'image',·'email',·'userName'
with "firstName",·"lastName",·"image",·"email",·"userName"
prettier/prettier
...include, | ||
{ | ||
model: User, | ||
as: 'author', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace 'author'
with "author"
prettier/prettier
What does this PR do?
Adjust the response from endpoint search?query='query'
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
NA
What are the relevant pivotal tracker stories?
#167737949
Screenshots (if appropriate)
NA
Questions:
NA