Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167737949 fix search by tag's response #46

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

tunedev
Copy link
Contributor

@tunedev tunedev commented Aug 6, 2019

What does this PR do?

Adjust the response from endpoint search?query='query'

Description of Task to be completed?

  • fix response of tag query to include authors details for easy card details

How should this be manually tested?

  • Clone this branch
  • Run npm install and npm test
  • Then run 'npm start`
  • Make a Get request to endpoint /search?tag='existing tag'
  • The response should consist of the article's author details

Any background context you want to provide?

NA

What are the relevant pivotal tracker stories?

#167737949

Screenshots (if appropriate)

NA

Questions:

NA

> - fix response of tag query to include authors details for easy card details

[Finishes #167737949]
@@ -307,7 +308,8 @@ describe('Search And Filter Tests', () => {
'readTime',
'image',
'tags',
'viewsCount'
'viewsCount',
'author'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'author' with "author" prettier/prettier

@@ -307,7 +308,8 @@ describe('Search And Filter Tests', () => {
'readTime',
'image',
'tags',
'viewsCount'
'viewsCount',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'viewsCount' with "viewsCount" prettier/prettier

@@ -86,6 +86,7 @@ describe('Search And Filter Tests', () => {
'readTime',
'image',
'viewsCount',
'author',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'author' with "author" prettier/prettier

{
model: User,
as: 'author',
attributes: ['firstName', 'lastName', 'image', 'email', 'userName']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'firstName',·'lastName',·'image',·'email',·'userName' with "firstName",·"lastName",·"image",·"email",·"userName" prettier/prettier

...include,
{
model: User,
as: 'author',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'author' with "author" prettier/prettier

@tunedev tunedev changed the title #167737949 fix response search #167737949 fix search by tag's response Aug 7, 2019
@nedemenang nedemenang merged commit 2b1af56 into develop Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants