Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167809483 fixes user verification and setup sendgrid #48

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

devPinheiro
Copy link
Contributor

What does this PR do?

  • It contains fixes for email verification and setup sendgrid

Description of Task to be completed?

  • install sendgrid
  • setup sendgrid with credentials
  • update mail helper

Any background context you want to provide?

none

What are the relevant pivotal tracker stories?

  • PT Story link - [#167809483] (https://www.pivotaltracker.com/story/show/167809483)

return sendgrid.send({
to: recipientMail,
subject,
from: 'persephone@andela.com',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'persephone@andela.com' with "persephone@andela.com" prettier/prettier

return sendgrid.send({
to: recipientMail,
subject,
from: 'persephone@andela.com',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'persephone@andela.com' with "persephone@andela.com" prettier/prettier

from: 'persephone@andela.com',
html: `Hi ${recipientName}. Welcome To Author's Haven.

Please click on this <a href="${process.env.FRONTEND_URL}/verify/${confirmCode}" >link</a> to confirm your email.`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace process.env.FRONTEND_URL with ⏎······process.env.FRONTEND_URL⏎···· prettier/prettier

return sendgrid.send({
to: recipientMail,
subject,
from: 'persephone@andela.com',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'persephone@andela.com' with "persephone@andela.com" prettier/prettier

@@ -1,7 +1,8 @@
import Mail from 'friendly-mail';
import sendgrid from '@sendgrid/mail';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace '@sendgrid/mail' with "@sendgrid/mail" prettier/prettier

@devPinheiro devPinheiro force-pushed the bg-fix-user-verification-167809483 branch from 7de9128 to 6ee2c9a Compare August 10, 2019 00:51
Copy link
Contributor

@fxola fxola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Sam. LGTM

install sendgrid
setup sendgrid with credentials
update mail helper
[Finishes #167809483]
@devPinheiro devPinheiro force-pushed the bg-fix-user-verification-167809483 branch from 6ee2c9a to 120096e Compare August 15, 2019 10:22
@nedemenang nedemenang merged commit 4dbfe3b into develop Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants