#168191815 bug fix to notify users when article is published #53
Conversation
To allow users receive notification when other users they are following publish an article [#168191815]
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -163,7 +163,7 @@ describe('Notification service', () => { | |||
| userId: userIdC, | |||
| likeUserId: userIdA, | |||
| articleSlug: | |||
| '/articles/temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam/comments/2' | |||
| 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' | |||
There was a problem hiding this comment.
Replace 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' with "temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam" prettier/prettier
| @@ -146,7 +146,7 @@ describe('Notification service', () => { | |||
| userId: userIdC, | |||
| commentUserId: userIdB, | |||
| articleSlug: | |||
| '/articles/temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam/comments/2', | |||
| 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam', | |||
There was a problem hiding this comment.
Replace 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' with "temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam" prettier/prettier
| @@ -80,7 +80,7 @@ describe('Notification service', () => { | |||
| userId: userIdA, | |||
| likeUserId: userIdB, | |||
| articleSlug: | |||
| '/articles/temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam/comments/2' | |||
| 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' | |||
There was a problem hiding this comment.
Replace 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' with "temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam" prettier/prettier
| @@ -63,7 +63,7 @@ describe('Notification service', () => { | |||
| userId: userIdA, | |||
| commentUserId: userIdB, | |||
| articleSlug: | |||
| '/articles/temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam/comments/2', | |||
| 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam', | |||
There was a problem hiding this comment.
Replace 'temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam' with "temporibus-labore-laborum-repudiandae-vitae-rerum-debitis-ut-quidem-quisquam" prettier/prettier
| @@ -5,6 +5,7 @@ import Helper from './helper'; | |||
| import model from '../db/models'; | |||
| import { paginationQueryMetadata, pageMetadata } from '../helpers/pagination'; | |||
| import { sendWelcomeEmail } from '../helpers/mail.helper'; | |||
| import { followNotification } from './notification.service'; | |||
There was a problem hiding this comment.
Replace './notification.service' with "./notification.service" prettier/prettier
|
|
||
| dotenv.config(); | ||
|
|
||
| const { Notification } = models; | ||
| const { Notification, Follow } = models; |
There was a problem hiding this comment.
'Follow' is assigned a value but never used no-unused-vars
| @@ -2,10 +2,11 @@ import Pusher from 'pusher'; | |||
| import dotenv from 'dotenv'; | |||
| import models from '../db/models'; | |||
| import { findUserById } from './auth.service'; | |||
| import { getUserFollowersService } from './user.service'; | |||
There was a problem hiding this comment.
Replace './user.service' with "./user.service" prettier/prettier
| @@ -471,6 +481,14 @@ export const createCommentService = async (userId, slug, commentDetails) => { | |||
| highlightedText: highlightedText || null | |||
| }); | |||
|
|
|||
| const details = { | |||
| userId: article['author.id'], | |||
There was a problem hiding this comment.
Replace 'author.id' with "author.id" prettier/prettier
| @@ -442,7 +452,7 @@ export const createCommentService = async (userId, slug, commentDetails) => { | |||
| { | |||
| model: User, | |||
| as: 'author', | |||
| attributes: ['firstName', 'lastName'], | |||
| attributes: ['id', 'firstName', 'lastName'], | |||
There was a problem hiding this comment.
Replace 'id',·'firstName',·'lastName' with "id",·"firstName",·"lastName" prettier/prettier
| commentArticleNotification, | ||
| likeCommentNotification, | ||
| sendNotificationOnArticlePublish | ||
| } from './notification.service'; |
There was a problem hiding this comment.
Replace './notification.service' with "./notification.service" prettier/prettier
What does this PR do?
To allow users to receive a notification when other users publish an article
Description of Task to be completed?
How should this be manually tested?
N/A
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#168191815
Screenshots (if appropriate)
N/A
Questions:
N/A