#167623915 Article card component #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halimahO
reviewed
Aug 2, 2019
src/components/ArticleCard/index.js
Outdated
|
|
||
| if (props.light) { | ||
| cardBodyClass.pop(); | ||
| cardBodyClass.push('light-theme'); |
There was a problem hiding this comment.
Good job on the light and dark theme.
devPinheiro
approved these changes
Aug 2, 2019
dharmykoya
changed the title
fxola
approved these changes
Aug 4, 2019
To install prop-types To create an article card component [#167623915]
dharmykoya
force-pushed
the
ft-article-card-167623915
branch
from
cae5d02
to
711ab38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
####What does this PR do?
To make the card article reusable component
Description of Task to be completed?
How should this be manually tested?
N/A
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#167623915
Screenshots (if appropriate)
Questions:
N/A