Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167701704 create homepage #23

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

devPinheiro
Copy link
Contributor

What does this PR do?

  • It contains a feature for setting up the app landing page

Description of Task to be completed?

  • create carousel component
  • fetch articles from the database by tags
  • added loading component
  • connect with redux store for state management
  • styled page for responsiveness
  • write integration test

How should this be manually tested?

  • After cloning the repo, cd into the root folder

  • Install all necessary dependencies by running

    npm install

  • Launch the node server with

    npm run dev

  • Using a web browser visit the link below:

    localhost:8080/

  • To run local tests using Jest

    npm test

Any background context you want to provide?

  • N/A

Screenshots

Screenshot 2019-08-07 at 5 42 57 PM

Screenshot 2019-08-07 at 5 43 09 PM

Screenshot 2019-08-07 at 5 43 30 PM

Screenshot 2019-08-07 at 5 43 56 PM

Screenshot 2019-08-07 at 5 44 34 PM

Screenshot 2019-08-07 at 5 44 40 PM

Screenshot 2019-08-07 at 5 44 45 PM

What are the relevant pivotal tracker stories?

  • PT Story link - [#167701704] (https://www.pivotaltracker.com/story/show/167701704)

Copy link
Contributor

@dharmykoya dharmykoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... well done team

Copy link
Contributor

@fxola fxola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job team. LGTM 💪🏽💪🏽

@halimahO halimahO force-pushed the ft-create-homepage-167701704 branch from f45b078 to 4ddb604 Compare August 8, 2019 19:25
@devPinheiro devPinheiro force-pushed the ft-create-homepage-167701704 branch 2 times, most recently from 0020087 to a3601e0 Compare August 9, 2019 09:57
@halimahO halimahO force-pushed the ft-create-homepage-167701704 branch from a3601e0 to 7834766 Compare August 9, 2019 10:03
create carousel component
fetch articles from database by tags
added loading component
connect with redux store for state management
styled page for responsiveness
write integration test
[Finishes #167701704]
@nedemenang nedemenang merged commit 93e4422 into develop Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants