[Feature: #163788958] Footer component #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XROLE
requested review from
andela-mabdussalam,
ebenezerdon,
habibaudu and
rajeman
as code owners
andela-mabdussalam
suggested changes
Feb 7, 2019
src/app/footer/Footer.js
Outdated
| /> | ||
| <FontAwesomeIcon | ||
| icon={['fab', 'twitter-square']} | ||
| style={{ fontSize: '25px', borderRadius: '50%', color: '#0E76A8' }} |
There was a problem hiding this comment.
Is there an alternative to styling this inline?
There was a problem hiding this comment.
Yes there is. I will do that asap
Create landing page component add style add fontawesome cdn install materialize-css install google font configure webpack to use google font
Create landing page component add style add fontawesome cdn install materialize-css install google font configure webpack to use google font
install font awesom packages refactore index.html file by removing fontawesom cdn create and style footer component write test for footer component [163788958]
XROLE
force-pushed
the
feature/163788958/footer-component
branch
from
899ba6a
to
f40aa2c
Compare
package.json
Outdated
| "serve": "node server.js", | ||
| "start": "npm run build && npm run serve", | ||
| "test": "jest --coverage --coverageReporters=text-lcov | coveralls", | ||
| "test:dev": "jest" |
There was a problem hiding this comment.
Let us add --coverage flag to test:dev, so that we can see the report locally.
There was a problem hiding this comment.
Ok. doing it right away
There was a problem hiding this comment.
For the --coverage this will need us to add coverage file with repo token as part of environment variables. Do I go ahead and add them?
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
|
|
||
| <link rel="stylesheet" href="css/style.css" /> | ||
| <link |
There was a problem hiding this comment.
Do we not need font-awesome anymore?
There was a problem hiding this comment.
Yes, we used it in the pen, books, users and social media icons
andela-mabdussalam
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
npm instalandnpm run start:devto see the home page attached with the footer componentnpm run test:devto see the test passing on localWhat are the relevant pivotal tracker stories?
Screenshots (if appropriate)