Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature:#163751546]Profile page #22

Merged
merged 26 commits into from
Feb 12, 2019
Merged

[Feature:#163751546]Profile page #22

merged 26 commits into from
Feb 12, 2019

Conversation

habibaudu
Copy link
Contributor

What does this PR do?

  • Create Profile and update profile page design only

Description of Task to be completed?

  • Create profile page
  • Create Update profile page
  • write tests

How should this be manually tested?

  • On terminal
    - Run npm run start:dev
    - url localhost:8080/profile

What are the relevant pivotal tracker stories?

@habibaudu habibaudu added the WIP label Feb 11, 2019
@habibaudu habibaudu removed the WIP label Feb 11, 2019
@habibaudu habibaudu changed the title Feature/163751546/profile page [Feature:#163751546]Profile page Feb 11, 2019
@rajeman rajeman temporarily deployed to pippin-ah-frontend February 11, 2019 14:14 Inactive
rajeman
rajeman reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@rajeman rajeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2019-02-11 at 3 18 52 pm

@habibaudu I noticed you left out the button for changing profile image. I also think the font in our figma template will be more appropriate for Profile, Biography, Top Five Articles etc. than the current one. You can check our figma template for those fonts.

@habibaudu
Copy link
Contributor Author

@rajeman when you click the profile update button it triggers a modal, there you will see the button to update profile picture.
I will look into our figma mockup to get the font
thanks

@habibaudu habibaudu temporarily deployed to pippin-ah-frontend February 11, 2019 16:34 Inactive
@habibaudu habibaudu temporarily deployed to pippin-ah-frontend February 11, 2019 16:49 Inactive
@rajeman rajeman temporarily deployed to pippin-ah-frontend February 11, 2019 21:41 Inactive
@andela-mabdussalam andela-mabdussalam temporarily deployed to pippin-ah-frontend February 12, 2019 15:20 Inactive
@habibaudu habibaudu temporarily deployed to pippin-ah-frontend February 12, 2019 15:26 Inactive
@habibaudu
feat():
14e7603 
fix style error
[#163751546]
@habibaudu habibaudu temporarily deployed to pippin-ah-frontend February 12, 2019 15:31 Inactive
@andela-mabdussalam andela-mabdussalam temporarily deployed to pippin-ah-frontend February 12, 2019 15:35 Inactive
@habibaudu
feat():
e9a58fb 
remove wave effect from profile picture
[#163751546]
@habibaudu habibaudu temporarily deployed to pippin-ah-frontend February 12, 2019 16:00 Inactive
@andela-mabdussalam andela-mabdussalam temporarily deployed to pippin-ah-frontend February 12, 2019 18:12 Inactive
@andela-mabdussalam andela-mabdussalam merged commit d25e5a8 into develop Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeman rajeman rajeman left review comments

@ebenezerdon ebenezerdon ebenezerdon approved these changes

@andela-mabdussalam andela-mabdussalam Awaiting requested review from andela-mabdussalam

@XROLE XROLE Awaiting requested review from XROLE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@habibaudu @rajeman @ebenezerdon @andela-mabdussalam