#137138341-Feature/Add Emojis To Chat #30
Conversation
| box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); | ||
| } | ||
| .emoji-picker-container { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| -webkit-box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); | ||
| -moz-box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); | ||
| box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| transform: relative; | ||
| -webkit-box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); | ||
| -moz-box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces0px should be written without units as 0
Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.
| overflow: hidden; | ||
| transform: relative; | ||
| -webkit-box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.1); |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Avoid vendor prefixes.0px should be written without units as 0
Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.
| border-radius: 2px; | ||
| overflow: hidden; | ||
| transform: relative; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
Avoid vendor prefixes.0px should be written without units as 0
Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.
| position: absolute; | ||
| z-index: 5002; | ||
| width: 220px; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| left: 2px !important; | ||
| position: absolute; | ||
| z-index: 5002; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| top: -280px !important; | ||
| left: 2px !important; | ||
| position: absolute; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| .emoji-menu { | ||
| top: -280px !important; | ||
| left: 2px !important; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| } | ||
| .emoji-menu { | ||
| top: -280px !important; |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
!important should not be used
| @@ -66,5 +66,7 @@ console.log(' Express app started on port ' + port); | |||
|
|
|||
| // Initializing logger | |||
| logger.init(app, passport, mongoose); | |||
| // expose ap | |||
|
|
|||
| //expose app | |||
There was a problem hiding this comment.
Expected space or tab after '//' in comment spaced-comment
| window.emojiPicker = new EmojiPicker({ | ||
| emojiable_selector: '[data-emojiable=true]', | ||
| assetsPath: 'https://cdn.rawgit.com/OneSignal/emoji-picker/gh-pages/lib/img/', | ||
| popupButtonClasses: 'fa fa-smile-o' |
There was a problem hiding this comment.
Strings must use doublequote quotes
| // Initializes and creates emoji set from sprite sheet | ||
| window.emojiPicker = new EmojiPicker({ | ||
| emojiable_selector: '[data-emojiable=true]', | ||
| assetsPath: 'https://cdn.rawgit.com/OneSignal/emoji-picker/gh-pages/lib/img/', |
There was a problem hiding this comment.
Strings must use doublequote quotes
| $(function () { | ||
| // Initializes and creates emoji set from sprite sheet | ||
| window.emojiPicker = new EmojiPicker({ | ||
| emojiable_selector: '[data-emojiable=true]', |
There was a problem hiding this comment.
Identifier 'emojiable_selector' is not in camel case camelcase
Strings must use doublequote quotes
| var msgElement = document.createElement('div'); | ||
|
|
||
| msgElement.className = 'msg'; | ||
| $('#results').append(msgAvatarElement).append(msgUsernameElement).append(msgTextElement); |
There was a problem hiding this comment.
Strings must use doublequote quotes
| }); | ||
|
|
||
| /** Function to add a data listener **/ | ||
| var startListening = function () { |
There was a problem hiding this comment.
Expected a function declaration func-style
| textInput.value = ''; | ||
| }); | ||
|
|
||
| /** Function to add a data listener **/ |
There was a problem hiding this comment.
Missing JSDoc @returns for function valid-jsdoc
| var msgText = textInput.value; | ||
| // replace myFirebase.set(...); with the next line | ||
| database.ref('msg').push({ avatar: msgAvatar, username: msgUser, text: msgText }); | ||
| textInput.value = ''; |
There was a problem hiding this comment.
Strings must use doublequote quotes
| var msgAvatar = avatarInput; | ||
| var msgText = textInput.value; | ||
| // replace myFirebase.set(...); with the next line | ||
| database.ref('msg').push({ avatar: msgAvatar, username: msgUser, text: msgText }); |
There was a problem hiding this comment.
Strings must use doublequote quotes
| const gameID = sessionStorage.getItem('gameID'); | ||
| const usernameInput = sessionStorage.getItem('Username'); | ||
| const avatarInput = sessionStorage.getItem('Avatar'); | ||
| const textInput = document.querySelector('#text'); |
There was a problem hiding this comment.
Strings must use doublequote quotes
public/js/controllers/game.js
Outdated
| } else { | ||
| $scope.pickedCards.pop(); | ||
| } | ||
| } | ||
|
|
||
| <<<<<<< HEAD |
aknwosu
force-pushed
the
feature/add-emojis-to-chat-137138347
branch
from
bde9a1c
to
ad493a4
Compare
What does this PR do?
This PR adds a feature to the chat message-box, supporting emojis and unicode characters.
Description of Task to be completed?
As a user in a game I want to be able to use emojis in the group chat so that I have a more enjoyable and expressive chat experience
How should this be manually tested?
Launch the Cards For Humanity project locally or on Heroku and navigate to the sign-in/sign-up screen. The pictures for the new sign-in and sign-up screen is attached in the screenshots below.
What are the relevant pivotal tracker stories?
Users should be able to use emojis in the chat window