Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/130341343/signup with jwt #9

Closed
wants to merge 39 commits into from
Closed

Feature/130341343/signup with jwt #9

wants to merge 39 commits into from

Conversation

a-okelawal
Copy link
Contributor

What does this PR do?

  • This PR creates an api for signing up that returns a JWT.

Description of Task to be completed?

  • Users once authenticated via the signup api should be returned a JWT to be required on subsequent call to all other endpoints that require authentication.
  • The criteria are:
    • GIVEN user successfully signs up or logs in
    • WHEN user passes appropriate JSON object to the /api/auth/signup endpoint
    • THEN user should receive a JWT as the response

How should this be manually tested?

  • This should be tested using the command mocha test/server/signup-spec.js

What are the relevant pivotal tracker stories?

  • Feature/#130341343

Screenshots (if appropriate)

  • When a user tries to sign up without the complete details
    screenshot 003
  • When a user already exists
    screenshot001
  • Successful sign up.
    screenshot002

Abisoye Oke-lawal added 25 commits September 21, 2016 23:07
chore(readme-update): update read me with new relevant info
6e5e129 
Finishes #130373385
Merge branch 'develop' of https://github.com/andela/project-kinsan in…
97d9dee 
…to develop

Update files in develop.
feature(signup): JWT for signup
1acf2f6 
Finishes #130341343
feature(signup): signup-with-jwt
074b90e 
-Update code in auth.js, routes.js, all.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
2286a21 
-Update code in auth.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
cd4145c 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
6c2f7e9 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
d9b2f2e 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
18e23eb 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
86efda3 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
ec04de9 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
Merge branch 'develop' of https://github.com/andela/project-kinsan in…
b8da309 
…to develop

- Merge changes with local develop.
feature(signup): JWT for signup
eeb1f2c 
Finishes #130341343
feature(signup): signup-with-jwt
e1f4163 
-Update code in auth.js, routes.js, all.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
c90e5b8 
-Update code in auth.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
bd1569b 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
5b5d6e5 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
704b82b 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
ff59f67 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
0941457 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
83c00cf 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
07c6fb6 
- Allow signup without the need of a token
Finishes #130341343
feature(signup): signup-with-jwt
5d4eec3 
- Rebase with develop branch
Finishes #130341343
make changes for rebase
553fead
feature(signup): signup-with-jwt
abf11c9 
- Rebase with develop branch
Finishes #130341343
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling abf11c9 on feature/130341343/signup-with-jwt into e8c42bb on develop.

ruqoyyasadiq
ruqoyyasadiq reviewed Oct 4, 2016
View reviewed changes
Copy link
Contributor

@ruqoyyasadiq ruqoyyasadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andela-abisoye I do not see the password hash implementation in the sign up method

Abisoye Oke-lawal added 3 commits October 4, 2016 16:34
feature(signup): JWT for signup
8e05d04 
Finishes #130341343
feature(signup): signup-with-jwt
948bc07 
-Update code in auth.js, routes.js, all.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
8b67e21 
-Update code in auth.js and signup-spec.js
to meet hound specifications.

Finishes #130341343
Abisoye Oke-lawal added 11 commits October 4, 2016 16:34
feature(signup): signup-with-jwt
6c269bc 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
1dafbd9 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
9a30745 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
c98e4ca 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
a9d0b4c 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
cbdfbfa 
-Update code in signup-spec.js
to meet hound specifications.

Finishes #130341343
feature(signup): signup-with-jwt
a4eeaf9 
- Allow user signup without token
Finishes #130341343
feature(signup): signup-with-jwt
a982721 
- Rebase with develop
Finishes #130341343
Pull from remote
2f1e90a
feature(signup): signup-with-jwt
d5b10e9 
- Rebase with develop
Finishes #130341343
feature(signup): signup-with-jwt
2d30bc4 
- Add password hashing function to signup
Finishes #130341343
@a-okelawal a-okelawal closed this Oct 4, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d30bc4 on feature/130341343/signup-with-jwt into e8c42bb on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruqoyyasadiq ruqoyyasadiq ruqoyyasadiq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-okelawal @coveralls @ruqoyyasadiq