#167271972 changes on comment #66
Conversation
#165413102 User should be able to logout
helpers/userHelper.js
Outdated
| currentUser.dataValues.following = !!userFollowing; | ||
| return currentUser; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/userHelper.js
Outdated
| currentUser.dataValues.following = !!userFollowing; | ||
| return currentUser; | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
helpers/commentHelper.js
Outdated
| currentComment.dataValues.histories = commentHistories; | ||
| return currentComment; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/commentHelper.js
Outdated
| currentComment.dataValues.histories = commentHistories; | ||
| return currentComment; | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
controllers/user.controller.js
Outdated
| `${process.env.FRONTEND_URL}/articles?token=${token}&username=${ | ||
| req.user.username | ||
| }` | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
controllers/user.controller.js
Outdated
| @@ -44,7 +51,11 @@ class UserController { | |||
| return res.status(500).send('Internal error'); | |||
| } | |||
| const token = helper.generateToken(newUser.dataValues); | |||
| return res.redirect(`${process.env.FRONTEND_URL}/articles?token=${token}&username=${req.user.username}`); | |||
| return res.redirect( | |||
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
controllers/user.controller.js
Outdated
| `${process.env.FRONTEND_URL}/articles?token=${token}&username=${ | ||
| req.user.username | ||
| }` | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
controllers/user.controller.js
Outdated
| if (isValidPassword) { | ||
| const token = helper.generateToken(userExist.dataValues); | ||
| return res.redirect(`${process.env.FRONTEND_URL}/articles?token=${token}&username=${req.user.username}`); | ||
| return res.redirect( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
controllers/article.controller.js
Outdated
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform(shares); | ||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform( | ||
| shares | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
controllers/article.controller.js
Outdated
| } | ||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform(shares); | ||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
Kabalisa
force-pushed
the
ch-changes-on-comment-#167271972
branch
from
3fed000
to
5c7ec44
Compare
-remove authorization on read comment -add orderby createdAt on fecth comments -fetch remaining comments after deleting a coment -fetch updated comments after updating a comment [finishes #167271972]
Kabalisa
force-pushed
the
ch-changes-on-comment-#167271972
branch
from
5c7ec44
to
e9df2e9
Compare
Description
I need to refactor the responses I get while deleting and updating comments. I also have to remove the requirement of authorization when a user needs to read comments on an article.
Type of change
How has it been tested
npm testChecklist:
N/A
Pivotal tracker story ID
#166161652